Skip to content

Meeting 7

Angeline Burrell edited this page Dec 21, 2020 · 1 revision

21 Dec 2020 15:00 GMT, 10:00 EST, 07:00 PST Present: Kate, Angeline, Alexa, Mack, Melissa, John

Reviewed code of conduct

Kate brought up two points to address. One was determined to be fine after reading it aloud. The other prompted a change. There was a point Mack had added to the Contributor Covenant Code of Conduct and reads:

"We offer the following additional example(s) of behavior that are unacceptable: ...

  • Disregarding the comments offered by reviewer(s) with intention of making a letter/recommendation more equitable."

Kate was concerned that there was no way to enforce this. Mack clarified that he wrote this with the intention of further encouraging submitters to take the review feedback seriously. John brought up that there are two potential populations of submitters: those who want feedback (and so are extremely likely to implement the suggested changes) and those who have bad intentions and would seek to troll ELSP online by publishing the review comments. Angeline agreed with this. John suggested replacing the current statement with one focused on the confidentiality of the review process. Since this is important ethically and something we can enforce, all agreed. The new wording is:

"- Violation of the confidentiality of the review process without the consent of the involved parties"

Discussed open pull requests

John had reviewed PR #21, and we decided that all of his suggestions were good and improved the document. Angeline was tasked to make these changes.

Alexa and Mack were tasked to review PRs #20 and #19, respectively.

Melissa presented the current state of the website in PR #18, which has a cleaner layout and more visible hover text. There is an issue with the font text size in some browser-operating system combinations on the Letter Example page, but this can be addressed outside of the current PR. Ways of protecting the ELSP email from bots were also discussed.

Issues and the path forward

Alexa has been working on a good nomination letter example, and will add it to the letter_anatomy branch for group feedback and workshopping.

All agreed that the current path forward is to merge all existing working branches into develop and polish the website to a point that we can conceivably publish it at or soon after the next meeting, which is set for 25 Jan 2021 15:00 GMT, 10:00 EST, 07:00 PST.

Tasks for next meeting:

  • Angeline - arrange next meeting, write up minutes, provide GitHub support, update incident form, edit the code of conduct, workshop the good nomination letter.
  • Alexa - Upload and workshop the good nomination letter. Review pull requests when tagged.
  • Kate - Review pull requests when tagged.
  • Mack - Review pull requests when tagged.
  • Mel - Add good nomination letter when finished, merge together current working branches into develop. Look into a contact form or other bot-protection methods.
  • John - Review pull requests when tagged.

Clone this wiki locally