feat: add expo-example app#76
Merged
Merged
Conversation
This was referenced Apr 1, 2026
f0d1057 to
accf679
Compare
9134f2e to
19af0fe
Compare
accf679 to
d265505
Compare
19af0fe to
67fc62b
Compare
d265505 to
ef7beaa
Compare
67fc62b to
7e8b5c9
Compare
ef7beaa to
a5a4190
Compare
7e8b5c9 to
6d49f74
Compare
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
SahilVasava
reviewed
Apr 28, 2026
Collaborator
SahilVasava
left a comment
There was a problem hiding this comment.
Looks solid. Three inline nits — naming, getPublicKey returning null, and lost yaml comments. Nothing blocking.
This was referenced Apr 29, 2026
6d49f74 to
e37a38e
Compare
7511324 to
a8f78a3
Compare
e37a38e to
72d702a
Compare
a8f78a3 to
cfa9016
Compare
be3dbfb to
2f776df
Compare
brtkx
approved these changes
May 13, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
mainCloses FS-1929
Added an
expo-exampleapp to testwallet-react. I needed to do a couple stuff to make Expo/Metro work with the monorepo and the packages:babel.config.jsto get rid of theimport.metaerrorAddednodeLinker: hoistedto the workspace file and the NPM config file.- This is needed to make the example app work, however, it can cause drawbacks with module resolution. (Source) We can discuss the best strategy here. On one hand, the example apps make it a lot easier to test the packages while developing. It's not a good option to install local modules in Expo as it's cumbersome and requires frequent bundle cache and
node_modulesresets. On the other hand, I do understand the drawbacks can be more annoying.Hoisted deps alone did not work to resolve multiple package versions so I had to add overrides here.Got inspired from Omar's PR and I added a Metro config instead to link to the correct modules. This might make some new package installs brittle so we need to keep extending it but it beats having to make global dep management modifications to the repo for the sake of an example app.
Claude's explanation: