feat(expo-example): migrate to expo-router#131
Merged
andrascodes merged 1 commit intoMay 14, 2026
Conversation
This was referenced Apr 28, 2026
andrascodes
commented
Apr 28, 2026
| @@ -0,0 +1,77 @@ | |||
| import 'react-native-get-random-values' | |||
Collaborator
Author
There was a problem hiding this comment.
This is basically the only file that needs to be reviewed in this PR. The rest is just moving the files around (and fixing file references) or following the Expo docs on setting up Expo Router.
This file implements the Protected routes (authenticated routes) and fixes a bug around using Wagmi on React Native which causes an error in development (set-state-in-render - manual reconnection solves it)
The SplashScreen should show until we can determine the authenticated status. This doesn't work on Android preview because of Expo. It only works in a production build.
This was referenced Apr 29, 2026
a3664fc to
d49848a
Compare
b9acfc8 to
e917bb8
Compare
31e2f8f to
fe9ea1e
Compare
c8b20c5 to
5cc1be4
Compare
fe9ea1e to
5818e6e
Compare
5cc1be4 to
a9b678f
Compare
e98b159 to
c466a44
Compare
6a5ec4c to
49caacd
Compare
OmarBasem
approved these changes
May 6, 2026
49caacd to
95c4d70
Compare
718a845 to
8944716
Compare
a36a497 to
c91dd13
Compare
8944716 to
425ad67
Compare
c91dd13 to
1c64fca
Compare
1c64fca to
34f2eee
Compare
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
mainCloses FS-2099
Decided to migrate the
expo-exampleapp to Expo Router to make the app resemble a production-grade app a bit more closely. Also, because the Magic Link callback I'm implementing in a subsequent PR works better using Expo Router.This also caused the appearance of some bugs:
set-state-in-renderwarning, which I handled with opting out ofreconnectOnMountand triggering thereconnect()manually in_layout/oauth-callbackwas processed by Expo-Router before (or in parallel) with the Native OAuth flow. I fixed it by just adding an explicit route for it and rendering anActivityIndicatormeanwhile theStack.Protectedusage in_layouttakes care of the redirection to the authenticated parts of the app. This can serve as an example of solving this issue in prod.