refactor(core): use atob and btoa instead of Buffer#72
Merged
andrascodes merged 1 commit intoMay 6, 2026
Merged
Conversation
This was referenced Apr 1, 2026
ebacb9a to
da2f27c
Compare
54fa0c4 to
1800c58
Compare
da2f27c to
f3577ac
Compare
This was referenced Apr 1, 2026
1800c58 to
7c1df70
Compare
4a78517 to
068598d
Compare
OmarBasem
reviewed
Apr 8, 2026
Collaborator
Author
Yes. No Buffer in Hermes. Do you have a better alternative solution for this? I'd be happy to change it. |
068598d to
c1d3e47
Compare
892cc8f to
3819862
Compare
3819862 to
f3b5f87
Compare
c1d3e47 to
746cf47
Compare
SahilVasava
previously approved these changes
Apr 28, 2026
Collaborator
SahilVasava
left a comment
There was a problem hiding this comment.
LGTM. Correctly addresses the base64url issue by doing the explicit -→+, _→/ conversion before atob. The Uint8Array + String.fromCharCode + btoa round-trip is the standard browser-safe pattern.
This was referenced Apr 28, 2026
746cf47 to
f35e00b
Compare
f3b5f87 to
dd8818e
Compare
1cb09ed to
8c73809
Compare
49ad4b7 to
2ba28ae
Compare
2ba28ae to
ffc0e8a
Compare
8c73809 to
c232734
Compare
ffc0e8a to
02e10cd
Compare
c232734 to
2c9c241
Compare
2c9c241 to
8c4ba7e
Compare
brtkx
approved these changes
May 6, 2026
SahilVasava
approved these changes
May 6, 2026
Collaborator
SahilVasava
left a comment
There was a problem hiding this comment.
LGTM (re-approving after force-push). atob/btoa swap is correct; base64url ↔ base64 conversion handled symmetrically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
mainCloses FS-1926
Removing the usage of Buffer and switching to
atobandbtoa+ using custom code. It works but this is probably best to replace with something more robust.