feat(expo-example): add Passkey auth and test on Android#124
Merged
andrascodes merged 1 commit intoMay 14, 2026
Merged
Conversation
This was referenced Apr 24, 2026
This was referenced Apr 24, 2026
ef7beaa to
a5a4190
Compare
ad00a9e to
358ac5e
Compare
SahilVasava
reviewed
Apr 28, 2026
| "storeFile file('debug.keystore')", | ||
| "storeFile file('../../credentials/debug.keystore')", | ||
| ) | ||
| return config |
Collaborator
There was a problem hiding this comment.
If Expo ever changes the prebuild template (different quote style, extra config block, etc.), this replace becomes a no-op and signing silently falls back to ~/.android/debug.keystore per machine — passkeys then break with no useful error.
Worth asserting the replacement actually happened:
const before = config.modResults.contents
config.modResults.contents = before.replace(
"storeFile file('debug.keystore')",
"storeFile file('../../credentials/debug.keystore')",
)
if (config.modResults.contents === before) {
throw new Error("withDebugKeystore: storeFile pattern not found in build.gradle — Expo prebuild template may have changed")
}Fails loud at prebuild time instead of silently breaking passkeys at runtime.
SahilVasava
reviewed
Apr 28, 2026
Collaborator
SahilVasava
left a comment
There was a problem hiding this comment.
Solid. One nit on the prebuild plugin to fail loud instead of silent.
This was referenced Apr 29, 2026
a5a4190 to
7511324
Compare
358ac5e to
8541e6d
Compare
7511324 to
a8f78a3
Compare
8541e6d to
0438fa5
Compare
a8f78a3 to
cfa9016
Compare
b3374f2 to
237bac1
Compare
cfa9016 to
1563159
Compare
1563159 to
e10eb90
Compare
9ffe3f0 to
d2a050e
Compare
e10eb90 to
75bbeaf
Compare
d2a050e to
9719484
Compare
c50c4eb to
0581bb2
Compare
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
OmarBasem
pushed a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack created with Aviator.
mainCloses FS-1928, FS-1999
The main purpose of the PR is setting up the Android build in a way that we can accomplish a PasskeyAuth on Android Emulator. Since the PasskeyStamper is already committed to the
expo-examplerepo I just added a component to the app to trigger the Passkey register/login (using the hook) - no other changes were needed to make it work.Changes explained:
assetlinks.json: a static json file deployed atzerodev-expo-example.vercel.app, this connects the domain to the app for App Links and Passkeys bothdebug.keystore: the app build needs to be signed with a key and the resulting fingerprint is added to theassetlinks.jsonfile this makes the connection between the app and the domain - this keystore is committed so every contributor can use it to sign the builds and test Passkeys and App LinkswithDebugKeystore.js: expo plugin applied so the Android prebuilds use thedebug.keystoreinstead of the one on the contributor's machinewagmi.configfiles for platform specific oneseas.json: setting up the EAS CLI for creating a local APK build that can be installed on a physical device or emulator,credentials.jsonis what this is looking for to get the signing credentials for the buildpnpm androidand a local APK build you get by runningpnpm dlx eas-cli build --platform android --local --profile preview. Both will use the committeddebug.keystorefor signing so Passkeys and App Links will work on both (both looks at thezerodev-expo-example.vercel.appdomain for verification).