Skip to content

feat(core): rename stampers and expose them on createZeroDevWallet#71

Merged
andrascodes merged 6 commits into
mainfrom
core_expose_stampers
May 6, 2026
Merged

feat(core): rename stampers and expose them on createZeroDevWallet#71
andrascodes merged 6 commits into
mainfrom
core_expose_stampers

Conversation

@andrascodes
Copy link
Copy Markdown
Collaborator

@andrascodes andrascodes commented Apr 1, 2026

Comment thread packages/core/src/utils/utils.ts Outdated
Comment thread packages/core/src/core/createZeroDevWallet.ts Outdated
Comment thread packages/core/src/types/session.ts Outdated
Comment thread packages/core/src/utils/exportPrivateKey.ts Outdated
Comment thread packages/core/src/utils/exportWallet.ts Outdated
Comment thread packages/core/src/utils/exportWallet.ts Outdated
Comment thread packages/core/src/core/createZeroDevWallet.ts Outdated
Comment thread packages/core/src/core/createZeroDevWallet.ts Outdated
Comment thread packages/core/src/core/createZeroDevWallet.ts Outdated
Comment thread packages/core/src/stampers/types.ts Outdated
Copy link
Copy Markdown
Collaborator

@SahilVasava SahilVasava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. The architectural direction is right — moving stampers to injected dependencies and the prepare/commit key rotation API is a clear improvement. Comments are mostly about consistency follow-through:

  • The StamperType rename is half-finished; doing it atomically here avoids the // TODO: @stamper-type markers landing in main.
  • publicKey field tightening surfaced a pre-existing weakness in the OAuth path (non-blocking).
  • Misc nits on docstrings.

Approve conceptually, just want the rename consistency before merge.

@andrascodes andrascodes force-pushed the core_expose_stampers branch from 2ba28ae to ffc0e8a Compare May 5, 2026 13:22
@andrascodes andrascodes changed the base branch from andras/feat-core-use-noble-ciphers-aes-for-mobile-compat to main May 5, 2026 14:30
@andrascodes andrascodes force-pushed the core_expose_stampers branch from ffc0e8a to 02e10cd Compare May 5, 2026 14:31
@andrascodes andrascodes requested a review from SahilVasava May 5, 2026 16:07
Copy link
Copy Markdown
Collaborator

@SahilVasava SahilVasava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — all prior review comments addressed (StamperType renamed to 'apiKey' | 'passkey', OAuth path now fails loud on missing public key, parseSession deduped to single token field, docstrings clarified).

@andrascodes andrascodes merged commit c3cd184 into main May 6, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants