Skip to content

feat(react): expose stamper, storage and shouldInit params#73

Merged
andrascodes merged 1 commit into
mainfrom
andras/feat-react-expose-stamper-storage-and-shouldinit-params
May 13, 2026
Merged

feat(react): expose stamper, storage and shouldInit params#73
andrascodes merged 1 commit into
mainfrom
andras/feat-react-expose-stamper-storage-and-shouldinit-params

Conversation

@andrascodes
Copy link
Copy Markdown
Collaborator

@andrascodes andrascodes commented Apr 1, 2026

@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from ebacb9a to da2f27c Compare April 1, 2026 17:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from e94d813 to de941af Compare April 1, 2026 17:11
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from da2f27c to f3577ac Compare April 1, 2026 21:08
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from de941af to 6e07c19 Compare April 1, 2026 21:08
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 6e07c19 to ca5f62a Compare April 7, 2026 11:21
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from f3577ac to 4a78517 Compare April 7, 2026 11:21
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from ca5f62a to 4bcc9a3 Compare April 7, 2026 16:17
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 4a78517 to 068598d Compare April 7, 2026 16:17
@andrascodes andrascodes marked this pull request as ready for review April 7, 2026 16:54
@OmarBasem
Copy link
Copy Markdown
Member

Passing through the new wallet-core options (storage, stampers...etc.) to wallet-react as well.
Additionally, removing or guarding the usages of window in wallet-react - added a shouldInit param to replace the check for "only init client-side" (still defaulting to typeof window !== "undefined" for now)

Can you please add more details on not just what is being changed, but also why, for more clarity and context

@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 068598d to c1d3e47 Compare April 20, 2026 10:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 4bcc9a3 to 5b62471 Compare April 20, 2026 10:11
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 5b62471 to 529ba6c Compare April 24, 2026 17:57
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from c1d3e47 to 746cf47 Compare April 24, 2026 17:57
Comment thread packages/react/src/connector.ts Outdated
Comment thread packages/react/src/connector.ts Outdated
Copy link
Copy Markdown
Collaborator

@SahilVasava SahilVasava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Substantive direction is right — exposing stamper, persistStorage, and shouldInitialize is exactly what RN consumers need. Three things inline:

  • 🔴 Dup-store: the new configured store is overwritten by the existing unconfigured one; persistStorage is dead until #75. Fold the deletion in here.
  • 🟡 Loosen Promise<Stamper>Stamper | Promise<Stamper> so sync stampers don't need wrapping.
  • ⚪ Naming nit: shouldInitializeautoInitialize.

Comment thread packages/react/src/connector.ts Outdated
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from f35e00b to d40889e Compare May 4, 2026 16:56
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch 2 times, most recently from 5567f74 to 6b4a7c0 Compare May 5, 2026 11:02
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from d40889e to 1cb09ed Compare May 5, 2026 11:02
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 6b4a7c0 to 87253c6 Compare May 5, 2026 11:28
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 1cb09ed to 8c73809 Compare May 5, 2026 11:28
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 87253c6 to fd133a8 Compare May 5, 2026 13:22
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 8c73809 to c232734 Compare May 5, 2026 13:22
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from fd133a8 to eb9665f Compare May 5, 2026 14:31
@andrascodes andrascodes requested a review from SahilVasava May 5, 2026 16:07
@andrascodes andrascodes force-pushed the andras/refactor-core-use-atob-and-btoa-instead-of-buffer branch from 2c9c241 to 8c4ba7e Compare May 6, 2026 12:18
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from eb9665f to 9441987 Compare May 6, 2026 12:18
@andrascodes andrascodes changed the base branch from andras/refactor-core-use-atob-and-btoa-instead-of-buffer to main May 6, 2026 13:26
@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 9441987 to cb83a89 Compare May 6, 2026 13:26
SahilVasava
SahilVasava previously approved these changes May 6, 2026
Copy link
Copy Markdown
Collaborator

@SahilVasava SahilVasava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — resolutions look good: stamper params now accept sync or async (ApiKeyStamper | Promise<ApiKeyStamper>), shouldInitialize renamed to autoInitialize with clear semantics, and the duplicate createZeroDevWalletStore block is gone.

@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from cb83a89 to 5ce572d Compare May 11, 2026 18:48
@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
zerodev-signer-demo Ready Ready Preview, Comment May 13, 2026 10:30am

Request Review

@andrascodes andrascodes force-pushed the andras/feat-react-expose-stamper-storage-and-shouldinit-params branch from 5ce572d to 9e9a6db Compare May 13, 2026 10:29
@andrascodes andrascodes merged commit cf2eafd into main May 13, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants