feat(react): expose stamper, storage and shouldInit params#73
Conversation
ebacb9a to
da2f27c
Compare
e94d813 to
de941af
Compare
da2f27c to
f3577ac
Compare
de941af to
6e07c19
Compare
6e07c19 to
ca5f62a
Compare
f3577ac to
4a78517
Compare
ca5f62a to
4bcc9a3
Compare
4a78517 to
068598d
Compare
Can you please add more details on not just what is being changed, but also why, for more clarity and context |
068598d to
c1d3e47
Compare
4bcc9a3 to
5b62471
Compare
5b62471 to
529ba6c
Compare
c1d3e47 to
746cf47
Compare
SahilVasava
left a comment
There was a problem hiding this comment.
Substantive direction is right — exposing stamper, persistStorage, and shouldInitialize is exactly what RN consumers need. Three things inline:
- 🔴 Dup-store: the new configured store is overwritten by the existing unconfigured one;
persistStorageis dead until #75. Fold the deletion in here. - 🟡 Loosen
Promise<Stamper>→Stamper | Promise<Stamper>so sync stampers don't need wrapping. - ⚪ Naming nit:
shouldInitialize→autoInitialize.
746cf47 to
f35e00b
Compare
529ba6c to
0259805
Compare
f35e00b to
d40889e
Compare
5567f74 to
6b4a7c0
Compare
d40889e to
1cb09ed
Compare
6b4a7c0 to
87253c6
Compare
1cb09ed to
8c73809
Compare
87253c6 to
fd133a8
Compare
8c73809 to
c232734
Compare
fd133a8 to
eb9665f
Compare
2c9c241 to
8c4ba7e
Compare
eb9665f to
9441987
Compare
9441987 to
cb83a89
Compare
SahilVasava
left a comment
There was a problem hiding this comment.
LGTM — resolutions look good: stamper params now accept sync or async (ApiKeyStamper | Promise<ApiKeyStamper>), shouldInitialize renamed to autoInitialize with clear semantics, and the duplicate createZeroDevWalletStore block is gone.
cb83a89 to
5ce572d
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5ce572d to
9e9a6db
Compare
This PR is part of a stack created with Aviator.
mainCloses FS-1927
Passing through the new
wallet-coreoptions (storage, stampers...etc.) towallet-reactas well.Additionally, removing or guarding the usages of
windowinwallet-react- added ashouldInitparam to replace the check for "only init client-side" (still defaulting totypeof window !== "undefined"for now)