Skip to content

feat: create react-native-kit#78

Merged
OmarBasem merged 5 commits into
mainfrom
omar/react-native-kit
Apr 10, 2026
Merged

feat: create react-native-kit#78
OmarBasem merged 5 commits into
mainfrom
omar/react-native-kit

Conversation

@OmarBasem
Copy link
Copy Markdown
Member

@OmarBasem OmarBasem commented Apr 2, 2026

Closes FS-1912

Summary

This PR sets up and creates react-native-kit package, and adds a react-native-example app (including react-native-web)

I will add storybook for react-native in a follow-up PR as it requires some extra setup
Can add it later whenever we need UI support on React Native

Just added one Button component to test the setup

@OmarBasem OmarBasem self-assigned this Apr 2, 2026
@OmarBasem OmarBasem marked this pull request as ready for review April 2, 2026 11:24
@OmarBasem OmarBasem changed the title [WIP] feat: create react-native-kit feat: create react-native-kit and react-native-example Apr 2, 2026
@OmarBasem OmarBasem requested review from andrascodes and brtkx April 2, 2026 11:24
@andrascodes
Copy link
Copy Markdown
Collaborator

@OmarBasem Would it be possible for you to split out react-native-kit into its own PR (or make this PR only for react-native-kit)? I already added an expo-example app here. Do you think it's possible for you to extend that?
The react-native-kit setup I'd like to merge before my stack, because I'd like to move some files (asyncSessionStorage, passkeyStamper, secureStoreStamper) over there and remove from the expo-example. It's possible also my stack would still be in review for a while and most of what's left for me to do is platform specific work so I'd probably make new PRs on top of the stack extending react-native-kit`. That's why I'd want that to be a separate PR.

@OmarBasem
Copy link
Copy Markdown
Member Author

@andrascodes no problem I can split it

@OmarBasem OmarBasem force-pushed the omar/react-native-kit branch from b1c4a67 to 0c5a096 Compare April 3, 2026 06:19
@OmarBasem OmarBasem changed the title feat: create react-native-kit and react-native-example feat: create react-native-kit Apr 3, 2026
brtkx
brtkx previously approved these changes Apr 10, 2026
andrascodes
andrascodes previously approved these changes Apr 10, 2026
Copy link
Copy Markdown
Collaborator

@andrascodes andrascodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!!!

@OmarBasem OmarBasem dismissed stale reviews from andrascodes and brtkx via 24106a5 April 10, 2026 09:46
@OmarBasem OmarBasem force-pushed the omar/react-native-kit branch from 0c5a096 to 24106a5 Compare April 10, 2026 09:46
@OmarBasem OmarBasem requested review from andrascodes and brtkx April 10, 2026 10:01
@OmarBasem OmarBasem merged commit 019199b into main Apr 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants