Skip to content

TOOLS-4148 Convert test/qa-tests/jstests/export/sort_and_skip.js to Go#942

Open
autarch wants to merge 1 commit into03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_convertingfrom
03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go
Open

TOOLS-4148 Convert test/qa-tests/jstests/export/sort_and_skip.js to Go#942
autarch wants to merge 1 commit into03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_convertingfrom
03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go

Conversation

@autarch
Copy link
Copy Markdown
Collaborator

@autarch autarch commented Mar 23, 2026

No description provided.

This was referenced Mar 23, 2026
Copy link
Copy Markdown
Collaborator Author

autarch commented Mar 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Comment on lines +2505 to +2507
for i := range 50 {
docs[i] = bson.D{{"a", int32(i)}}
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this kinda defeats the purpose of testing sort behavior right? The js test inserted in scrambled order, whereas this inserts in sorted order.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, actuallly ... the AI pointed out that WiredTiger doesn't guarantee an order for an unsorted query ... but I added a shuffle.

@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from d2af7eb to bd6dda5 Compare March 25, 2026 20:34
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from 23e06c2 to baf5f6b Compare March 25, 2026 20:39
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch 2 times, most recently from 8d588e1 to dd0f926 Compare March 25, 2026 20:42
@autarch autarch requested a review from nickweinberger March 25, 2026 20:42
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from baf5f6b to cbe1672 Compare March 25, 2026 20:47
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from dd0f926 to a2c80f3 Compare March 25, 2026 20:47
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from cbe1672 to d07acc9 Compare March 26, 2026 01:20
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from a2c80f3 to 0b40e48 Compare March 26, 2026 01:22
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from 0b40e48 to e094256 Compare March 26, 2026 17:08
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from d07acc9 to c0cbbd2 Compare March 26, 2026 17:08
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from e094256 to a7ee667 Compare March 26, 2026 17:23
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch 2 times, most recently from 714f3a9 to 6f4a1ed Compare March 26, 2026 21:53
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from a7ee667 to 549c6e4 Compare March 26, 2026 21:53
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from 6f4a1ed to 80ac0a7 Compare March 26, 2026 22:02
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from 549c6e4 to 70aa195 Compare March 26, 2026 22:02
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting branch from 80ac0a7 to f75615a Compare March 26, 2026 22:03
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from 70aa195 to 17dfb1c Compare March 26, 2026 22:03
@autarch autarch changed the base branch from 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting to graphite-base/942 March 27, 2026 18:27
@autarch autarch force-pushed the graphite-base/942 branch from f75615a to 9f7f730 Compare March 27, 2026 20:27
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/sort_and_skip.js_to_go branch from 17dfb1c to 683ad8d Compare March 27, 2026 20:27
@autarch autarch changed the base branch from graphite-base/942 to 03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting March 27, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants