Skip to content

TOOLS-4148 Convert test/qa-tests/jstests/export/limit.js to Go#935

Open
autarch wants to merge 1 commit into03-23-convert_test/qa-tests/jstests/export/json_array.js_to_gofrom
03-23-convert_test/qa-tests/jstests/export/limit.js_to_go
Open

TOOLS-4148 Convert test/qa-tests/jstests/export/limit.js to Go#935
autarch wants to merge 1 commit into03-23-convert_test/qa-tests/jstests/export/json_array.js_to_gofrom
03-23-convert_test/qa-tests/jstests/export/limit.js_to_go

Conversation

@autarch
Copy link
Collaborator

@autarch autarch commented Mar 23, 2026

No description provided.

Copy link
Collaborator Author

autarch commented Mar 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@autarch autarch requested a review from a team as a code owner March 24, 2026 15:03
@autarch autarch requested review from tdq45gj and removed request for a team March 24, 2026 15:03
@autarch autarch changed the title Convert test/qa-tests/jstests/export/limit.js to Go TOOLS-4148 Convert test/qa-tests/jstests/export/limit.js to Go Mar 24, 2026
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/limit.js_to_go branch from ee72707 to 75b77b7 Compare March 25, 2026 20:34
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/json_array.js_to_go branch 2 times, most recently from 74ba0f6 to 4d6dc91 Compare March 25, 2026 20:48
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/limit.js_to_go branch from 75b77b7 to 0b2dcb8 Compare March 25, 2026 20:48
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/json_array.js_to_go branch from 4d6dc91 to bc01294 Compare March 26, 2026 01:16
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/limit.js_to_go branch from 0b2dcb8 to 1d0ba07 Compare March 26, 2026 01:17
}

// TestRoundTripLimit verifies that mongoexport --limit restricts the number of
// exported documents, and that the correct documents are restored (from limit.js).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comments still references limit.js, but it's removed. I think we should either clarify where to find the legacy file or just remove the reference.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/limit.js_to_go branch from 1d0ba07 to 824db1f Compare March 26, 2026 17:08
@autarch autarch requested a review from tdq45gj March 26, 2026 17:10
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/json_array.js_to_go branch from 5375590 to f07594a Compare March 26, 2026 21:53
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/limit.js_to_go branch from 824db1f to 0487c3a Compare March 26, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants