Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ad10d8f to
f8d80ef
Compare
f8d80ef to
b8c834c
Compare
b8c834c to
e16e09e
Compare
162b6ad to
a3170ff
Compare
55feed5 to
057c6bb
Compare
a3170ff to
e787652
Compare
057c6bb to
22b912b
Compare
e787652 to
7a9eeeb
Compare
This was referenced Mar 20, 2026
7a9eeeb to
fbdcd63
Compare
4e37557 to
c1284b7
Compare
This was referenced Mar 23, 2026
FGasper
approved these changes
Mar 24, 2026
Collaborator
FGasper
left a comment
There was a problem hiding this comment.
AFAICT this is fine. It does contextualize a bit why (in the next PR) AI wants to skip the SIGPIPE tests. I still hesitate to remove coverage entirely, though, and wonder if we can’t preserve an OS-level test that builds the tool in question & runs it from Go.
| defer client.Disconnect(context.Background()) | ||
|
|
||
| db := client.Database("mongofoo_test_db") | ||
| defer db.Drop(context.Background()) // clean up after the test |
Collaborator
There was a problem hiding this comment.
Should use t.Context() instead.
|
|
||
| t.Run("does the thing", func(t *testing.T) { | ||
| // Insert test data | ||
| _, err := db.Collection("coll").InsertOne(context.Background(), bson.D{{"k", "v"}}) |
|
|
||
| // Assert outcomes | ||
| var result bson.D | ||
| err = db.Collection("coll").FindOne(context.Background(), bson.D{}).Decode(&result) |
09a82fc to
88df719
Compare
493873b to
21e4728
Compare
88df719 to
c004698
Compare
21e4728 to
1085693
Compare
c004698 to
b7e4b4c
Compare
1085693 to
766992b
Compare
Collaborator
Author
Merge activity
|
766992b to
aede66b
Compare
This adds anew `TOOLS_TESTING_SHARDED_INTEGRATION` test type, wires it up in the build script via -topology=sharded, adds a "create sharded cluster" Evergreen function (mirroring "create repl_set" but using ShardingTest), and adds integration-X.Y-sharded tasks for all server versions that have cluster tasks (4.4 through latest). Co-Authored-By: Claude Code <noreply@anthropic.com>
aede66b to
032769f
Compare
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds a new
TOOLS_TESTING_SHARDED_INTEGRATIONtest type, wires it up in the build script via -topology=sharded, adds a "create sharded cluster" Evergreen function (mirroring "create repl_set" but using ShardingTest), and adds integration-X.Y-sharded tasks for all server versions that have cluster tasks (4.4 through latest).This will be used as I convert JS tests to Go. Some of those tests are specific to sharded clusters, so we need a way to write Go tests against sharded clusters too.
This PR also includes the plan that Claude created for the conversion of all JS tests.