Skip to content

TOOLS-4148 Add a new sharded test type for sharded cluster integration tests#916

Merged
autarch merged 1 commit intomasterfrom
03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests
Mar 26, 2026
Merged

TOOLS-4148 Add a new sharded test type for sharded cluster integration tests#916
autarch merged 1 commit intomasterfrom
03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests

Conversation

@autarch
Copy link
Copy Markdown
Collaborator

@autarch autarch commented Mar 13, 2026

This adds a new TOOLS_TESTING_SHARDED_INTEGRATION test type, wires it up in the build script via -topology=sharded, adds a "create sharded cluster" Evergreen function (mirroring "create repl_set" but using ShardingTest), and adds integration-X.Y-sharded tasks for all server versions that have cluster tasks (4.4 through latest).

This will be used as I convert JS tests to Go. Some of those tests are specific to sharded clusters, so we need a way to write Go tests against sharded clusters too.

This PR also includes the plan that Claude created for the conversion of all JS tests.

Copy link
Copy Markdown
Collaborator Author

autarch commented Mar 13, 2026

@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch 3 times, most recently from ad10d8f to f8d80ef Compare March 19, 2026 17:09
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from f8d80ef to b8c834c Compare March 20, 2026 16:53
@autarch autarch changed the base branch from master to graphite-base/916 March 20, 2026 18:14
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from b8c834c to e16e09e Compare March 20, 2026 18:14
@autarch autarch changed the base branch from graphite-base/916 to 03-20-add_an_agents.md_file_for_this_repo March 20, 2026 18:14
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch 2 times, most recently from 162b6ad to a3170ff Compare March 20, 2026 18:31
@autarch autarch force-pushed the 03-20-add_an_agents.md_file_for_this_repo branch from 55feed5 to 057c6bb Compare March 20, 2026 18:31
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from a3170ff to e787652 Compare March 20, 2026 20:34
@autarch autarch force-pushed the 03-20-add_an_agents.md_file_for_this_repo branch from 057c6bb to 22b912b Compare March 20, 2026 20:34
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from e787652 to 7a9eeeb Compare March 20, 2026 20:35
@autarch autarch changed the base branch from 03-20-add_an_agents.md_file_for_this_repo to graphite-base/916 March 20, 2026 21:26
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from 7a9eeeb to fbdcd63 Compare March 20, 2026 21:26
@autarch autarch changed the base branch from graphite-base/916 to 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ March 20, 2026 21:26
@autarch autarch marked this pull request as ready for review March 20, 2026 21:27
@autarch autarch requested a review from a team as a code owner March 20, 2026 21:27
@autarch autarch requested review from FGasper and nickweinberger and removed request for a team and nickweinberger March 20, 2026 21:27
@autarch autarch force-pushed the 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ branch from 4e37557 to c1284b7 Compare March 23, 2026 15:07
Copy link
Copy Markdown
Collaborator

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is fine. It does contextualize a bit why (in the next PR) AI wants to skip the SIGPIPE tests. I still hesitate to remove coverage entirely, though, and wonder if we can’t preserve an OS-level test that builds the tool in question & runs it from Go.

defer client.Disconnect(context.Background())

db := client.Database("mongofoo_test_db")
defer db.Drop(context.Background()) // clean up after the test
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use t.Context() instead.


t.Run("does the thing", func(t *testing.T) {
// Insert test data
_, err := db.Collection("coll").InsertOne(context.Background(), bson.D{{"k", "v"}})
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.Context()


// Assert outcomes
var result bson.D
err = db.Collection("coll").FindOne(context.Background(), bson.D{}).Decode(&result)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t.Context

@autarch autarch changed the title Add a new sharded test type for sharded cluster integration tests TOOLS-4148 Add a new sharded test type for sharded cluster integration tests Mar 24, 2026
@autarch autarch force-pushed the 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ branch from 09a82fc to 88df719 Compare March 25, 2026 16:50
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from 493873b to 21e4728 Compare March 25, 2026 16:50
@autarch autarch force-pushed the 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ branch from 88df719 to c004698 Compare March 25, 2026 16:59
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from 21e4728 to 1085693 Compare March 25, 2026 16:59
@autarch autarch force-pushed the 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ branch from c004698 to b7e4b4c Compare March 25, 2026 17:15
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from 1085693 to 766992b Compare March 25, 2026 17:15
Copy link
Copy Markdown
Collaborator Author

autarch commented Mar 25, 2026

Merge activity

  • Mar 25, 8:31 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 25, 8:35 PM UTC: The Graphite merge of this pull request was cancelled.
  • Mar 25, 8:54 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 25, 8:55 PM UTC: Graphite couldn't merge this pull request because a downstack PR Add an AGENTS.md file for this repo #924 failed to merge.
  • Mar 25, 9:08 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 25, 9:08 PM UTC: Graphite couldn't merge this pull request because a downstack PR Add an AGENTS.md file for this repo #924 failed to merge.
  • Mar 25, 9:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 26, 12:39 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 26, 1:10 AM UTC: @autarch merged this pull request with Graphite.

@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from 766992b to aede66b Compare March 25, 2026 20:47
@autarch autarch changed the base branch from 03-20-fix_linting_ignore_rule_for_bson_types_like_bson.d_ to graphite-base/916 March 25, 2026 23:49
@autarch autarch changed the base branch from graphite-base/916 to master March 26, 2026 00:38
This adds anew `TOOLS_TESTING_SHARDED_INTEGRATION` test type, wires it up in the build script via -topology=sharded, adds a "create sharded cluster" Evergreen function (mirroring "create repl_set" but using ShardingTest), and adds integration-X.Y-sharded tasks for all server versions that have cluster tasks (4.4 through latest).

Co-Authored-By: Claude Code <noreply@anthropic.com>
@autarch autarch force-pushed the 03-13-add_a_new_sharded_test_type_for_sharded_cluster_integration_tests branch from aede66b to 032769f Compare March 26, 2026 00:39
@autarch autarch merged commit 48c54ef into master Mar 26, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants