TOOLS-4148 Delete test/qa-tests/jstests/export/slave_ok.js without converting#941
Open
autarch wants to merge 1 commit into03-23-convert_test/qa-tests/jstests/export/query.js_to_gofrom
Conversation
This was referenced Mar 23, 2026
Collaborator
Author
This was referenced Mar 23, 2026
mmcclimon
approved these changes
Mar 24, 2026
Contributor
mmcclimon
left a comment
mmcclimon
left a comment
There was a problem hiding this comment.
LGTM, thanks. (Also: oof.)
You probably don't know the answer to this, but: are we ever going to be able to delete all these deprecated options?
autarch
changed the title
test/qa-tests/jstests/export/slave_ok.js without convertingtest/qa-tests/jstests/export/slave_ok.js without converting
Collaborator
Author
No clue. I think we'd need to discuss with Product, but they're pretty busy with other things at the moment. |
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
from
1cb2466 to
8507124
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
2 times, most recently
from
23e06c2 to
baf5f6b
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
from
8507124 to
21d514f
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
from
baf5f6b to
cbe1672
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
2 times, most recently
from
b967fbc to
ca41444
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
from
cbe1672 to
d07acc9
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
from
ca41444 to
9569b1c
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
2 times, most recently
from
c0cbbd2 to
714f3a9
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
2 times, most recently
from
57ed695 to
ea8294e
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
from
714f3a9 to
6f4a1ed
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
from
ea8294e to
f746854
Compare
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
from
6f4a1ed to
80ac0a7
Compare
The `--slaveOk` flag is hidden and deprecated. It's the equivalent of setting ` readPreference=nearest` in the connection string.
autarch
force-pushed
the
03-23-delete_test/qa-tests/jstests/export/slave_ok.js_without_converting
branch
from
80ac0a7 to
f75615a
Compare
autarch
force-pushed
the
03-23-convert_test/qa-tests/jstests/export/query.js_to_go
branch
from
f746854 to
f66c519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--slaveOkflag is hidden and deprecated. It's the equivalent of settingreadPreference=nearestin the connection string.