TOOLS-4148 Rewrite all the bsondump tests in Go and delete the JS tests for this by autarch · Pull Request #923 · mongodb/mongo-tools

autarch · 2026-03-19T17:09:08Z

A few of the JS tests were not ported, per the plan in docs/superpowers

autarch · 2026-03-19T17:09:22Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

FGasper

Looks like the refactor reduced coverage in one test and imprudently skipped another.

bsondump/bsondump_test.go

FGasper · 2026-03-23T13:39:36Z

bsondump/bsondump_test.go

+	badFiles := []string{
+		"testdata/bad_cstring.bson",
+		"testdata/bad_type.bson",
+		"testdata/invalid_field_name.bson",
+		"testdata/partial_file.bson",
+		"testdata/random_bytes.bson",
+	}


The refactoring of these tests makes it kind of hard to compare with the originals.

It might be nice if the AI privileged line-for-line translation rather than trying to refactor.

It can do that, but do we really want that? If a human did this work I'm sure they'd do this same refactor. The way the JS test was written is just wrong. It should have used a loop!

I agree that the original test’s copy-paste-ness was excessive.

The refactor, though, makes it hard to ensure that the test was ported faithfully. I found one spot in this PR where Claude dropped something earlier; verifying that there isn’t something else is easier when the Go code resembles the JS.

I’m not blocking on this, btw … but it might be a good parameter to give the AI in future translations.

If you think the existing set of PRs are a lot to review, imagine effectively doubling the number of PRs by breaking it up into "rewrite the JS test exactly into Go" and then "rewrite that into sane Go code". Is that a tradeoff we really want? I think the real problem with this PR is that I should've just done one test at a time.

test/qa-tests/jstests/bson/bsondump_broken_pipe.js

A few of the JS tests were not ported, per the plan in docs/superpowers

This was referenced Mar 19, 2026

TOOLS-4148 Add a new sharded test type for sharded cluster integration tests #916

Merged

TOOLS-4148 Annotate JS tests with SKIP, EXTEND, or NEW after auditing to figure out which ones need to be converted to Go #922

Closed

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 629d309 to 314536f Compare March 20, 2026 16:53

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch from 2d4c1a3 to 8602a4d Compare March 20, 2026 16:53

autarch mentioned this pull request Mar 20, 2026

Add an AGENTS.md file for this repo #924

Merged

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 314536f to af5f557 Compare March 20, 2026 18:31

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch 2 times, most recently from 951bc97 to 7a3fa74 Compare March 20, 2026 20:34

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch 2 times, most recently from 6cbeff6 to 5c182e0 Compare March 20, 2026 20:35

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch from 7a3fa74 to be4d1de Compare March 20, 2026 20:35

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 5c182e0 to 6a8bc27 Compare March 20, 2026 20:38

autarch mentioned this pull request Mar 20, 2026

TOOLS-4148 Convert test/qa-tests/jstests/export/basic_data.js to Go #925

Open

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 6a8bc27 to ce94d63 Compare March 20, 2026 21:26

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch from be4d1de to 13b1165 Compare March 20, 2026 21:26

This was referenced Mar 20, 2026

Fix linting ignore rule for bson types like bson.D #926

Merged

TOOLS-4148 Convert test/qa-tests/jstests/export/data_types.js to Go #927

Open

autarch marked this pull request as ready for review March 20, 2026 21:27

autarch requested a review from a team as a code owner March 20, 2026 21:27

autarch requested review from FGasper and mankawal and removed request for a team and mankawal March 20, 2026 21:27

FGasper requested changes Mar 23, 2026

View reviewed changes

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from ce94d63 to 93cafd5 Compare March 23, 2026 15:07

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch from 13b1165 to aae3a48 Compare March 23, 2026 15:07

autarch requested a review from FGasper March 23, 2026 15:07

autarch force-pushed the 03-18-migration_annotate_js_tests_with_verified_go_coverage_triage branch from aae3a48 to 66aa6b5 Compare March 23, 2026 15:30

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 93cafd5 to d6504ac Compare March 23, 2026 15:30

autarch force-pushed the graphite-base/923 branch from d93b762 to a7a8c12 Compare March 26, 2026 16:53

autarch changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 26, 2026 16:54

autarch changed the base branch from 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe to graphite-base/923 March 26, 2026 21:36

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 94cbc99 to a0ef32f Compare March 26, 2026 21:53

autarch force-pushed the graphite-base/923 branch from a7a8c12 to 8887a8d Compare March 26, 2026 21:53

autarch changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 26, 2026 21:53

This was referenced Mar 26, 2026

TOOLS-4148 Convert mode_upsert_id_subdoc.js to Go #964

Draft

Add a Claude skill for converting JS tests to Go #965

Draft

autarch changed the base branch from 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe to graphite-base/923 March 27, 2026 18:27

autarch force-pushed the graphite-base/923 branch from 8887a8d to f183501 Compare March 27, 2026 18:27

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from a0ef32f to b457216 Compare March 27, 2026 18:27

autarch changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 27, 2026 18:27

autarch changed the base branch from 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe to graphite-base/923 March 27, 2026 18:43

autarch mentioned this pull request Mar 27, 2026

Fix evergreen-validate failures in CI #966

Merged

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from b457216 to 9db3a63 Compare March 27, 2026 20:27

autarch force-pushed the graphite-base/923 branch from f183501 to 4e2c586 Compare March 27, 2026 20:27

autarch changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 27, 2026 20:27

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 9db3a63 to de8522d Compare March 27, 2026 21:12

autarch force-pushed the 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe branch from 4e2c586 to 1563a49 Compare March 27, 2026 21:12

autarch changed the base branch from 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe to graphite-base/923 March 27, 2026 21:13

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from de8522d to 3f6ec50 Compare March 27, 2026 21:14

autarch force-pushed the graphite-base/923 branch from 1563a49 to f440194 Compare March 27, 2026 21:14

autarch changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 27, 2026 21:14

autarch force-pushed the 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe branch from f440194 to beca1d3 Compare March 27, 2026 21:15

Rewrite all the bsondump tests in Go and delete the JS tests for this

41037a4

A few of the JS tests were not ported, per the plan in docs/superpowers

autarch force-pushed the 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe branch from beca1d3 to 3f1896d Compare March 27, 2026 21:15

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 3f6ec50 to 4243504 Compare March 27, 2026 21:16

autarch changed the base branch from 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe to graphite-base/923 March 27, 2026 21:16

graphite-app bot changed the base branch from graphite-base/923 to 03-25-add_a_new_test_in_common_for_our_handling_of_sigpipe March 27, 2026 21:16

autarch force-pushed the 03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this branch from 4243504 to 41037a4 Compare March 27, 2026 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TOOLS-4148 Rewrite all the bsondump tests in Go and delete the JS tests for this#923

TOOLS-4148 Rewrite all the bsondump tests in Go and delete the JS tests for this#923
autarch wants to merge 1 commit into03-25-add_a_new_test_in_common_for_our_handling_of_sigpipefrom
03-19-rewrite_all_the_bsondump_tests_in_go_and_delete_the_js_tests_for_this

autarch commented Mar 19, 2026

Uh oh!

autarch commented Mar 19, 2026 •

edited

Loading

Uh oh!

FGasper left a comment

Uh oh!

Uh oh!

FGasper Mar 23, 2026

Uh oh!

autarch Mar 23, 2026

Uh oh!

FGasper Mar 24, 2026

Uh oh!

FGasper Mar 24, 2026

Uh oh!

autarch Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

autarch commented Mar 19, 2026

Uh oh!

autarch commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FGasper left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FGasper Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

autarch Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

FGasper Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

FGasper Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

autarch Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

autarch commented Mar 19, 2026 •

edited

Loading