Skip to content

TOOLS-4148 Delete test/qa-tests/jstests/export/force_table_scan.js without converting#933

Open
autarch wants to merge 1 commit into03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_gofrom
03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting
Open

TOOLS-4148 Delete test/qa-tests/jstests/export/force_table_scan.js without converting#933
autarch wants to merge 1 commit into03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_gofrom
03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting

Conversation

@autarch
Copy link
Collaborator

@autarch autarch commented Mar 23, 2026

The --forceTableScan option was deprecated when WiredTiger became the default in MongoDB 3.0 and mmapv1 was removed in 4.2. On 4.2+ the flag is a no-op and the profiling assertions in the JS test are trivially true.

Copy link
Collaborator Author

autarch commented Mar 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@autarch autarch marked this pull request as ready for review March 24, 2026 15:02
@autarch autarch requested a review from a team as a code owner March 24, 2026 15:02
@autarch autarch requested review from mmcclimon and removed request for a team March 24, 2026 15:02
Copy link
Contributor

@mmcclimon mmcclimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Also, a meta-comment: is there a ticket number for this work? It would be good to make one, even a catch-all, because (I think?) we use JIRA to generate the release changelogs.

@autarch autarch changed the title Delete test/qa-tests/jstests/export/force_table_scan.js without converting TOOLS-4148 Delete test/qa-tests/jstests/export/force_table_scan.js without converting Mar 24, 2026
Copy link
Collaborator Author

autarch commented Mar 24, 2026

I added a ticket.

@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting branch from 8643c88 to e1455f5 Compare March 25, 2026 20:34
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_go branch from a653fc2 to a65a390 Compare March 25, 2026 20:34
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting branch from e1455f5 to c1ad1af Compare March 25, 2026 20:47
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_go branch from 544a99b to 258f261 Compare March 26, 2026 01:15
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting branch from c1ad1af to f58ffd7 Compare March 26, 2026 01:16
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting branch from f58ffd7 to 3985cd1 Compare March 26, 2026 17:08
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_go branch from 258f261 to 1ba6bd2 Compare March 26, 2026 17:08
…verting

The `--forceTableScan` option was deprecated when WiredTiger became the default in MongoDB 3.0 and mmapv1 was removed in 4.2. On 4.2+ the flag is a no-op and the profiling assertions in the JS test are trivially true.
@autarch autarch force-pushed the 03-23-delete_test/qa-tests/jstests/export/force_table_scan.js_without_converting branch from 3985cd1 to 29b7248 Compare March 26, 2026 21:53
@autarch autarch force-pushed the 03-23-convert_test/qa-tests/jstests/export/fields_json.js_to_go branch from 1ba6bd2 to 0f62404 Compare March 26, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants