apollo_network_benchmark: add message index detection mechanism

[sirandreww-starkware]

Note

Medium Risk
Introduces new concurrent task wiring and unbounded channel usage in the hot receive path; misuse of peer indexing/unwrap() could cause panics or inaccurate metrics under load.

Overview
Adds an async message-index tracking path to the broadcast stress test receiver: received messages now forward (sender_id, message_index) over an unbounded channel to a new record_indexed_message task which maintains per-peer MessageIndexTrackers and updates a new RECEIVE_MESSAGE_PENDING_COUNT gauge.

Wires this into BroadcastNetworkStressTestNode by splitting the receiver into two tasks (receiver + tracker) and removes the dead_code allowance from message_index_detector.rs now that it’s used.

^{Written by Cursor Bugbot for commit a85e9be. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557 👈 (View in Graphite)
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Sender ID indexing can panic receiver

High Severity

record_indexed_message indexes index_tracker by sender_id, but the vector is sized with bootstrap.len(). This assumes sender IDs are dense zero-based indices, which NodeArgs.runner.id does not enforce. Valid deployments with sparse or non-zero-based IDs can trigger out-of-bounds access and crash the receiver path.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/stress_test_node.rs#L150-L151

 

[cursor]

Index tracker sized by bootstrap peers, indexed by sender_id

High Severity

num_peers is set to self.args.runner.bootstrap.len(), which is the number of other peers (N−1 for N nodes). But record_indexed_message uses this to size index_tracker and indexes it by sender_id (which is runner.id, ranging from 0 to N−1). For the node with the highest ID, index_tracker[N-1] is out of bounds on a vec of length N−1, causing a panic at runtime.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/handlers.rs#L103-L107

 

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

Pending count underflows on duplicate message indices

Medium Severity

MessageIndexTracker::pending_messages_count() computes max - min + 1 - seen_messages_count. Since seen_message() always increments seen_messages_count without checking for duplicates, receiving the same message_index twice makes seen_messages_count exceed the actual index range, causing a u64 subtraction underflow (panic in debug, wrap in release). The new record_indexed_message function is the first caller of this code path, activating this latent issue.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/message_index_detector.rs#L1-L6