apollo_network_benchmark: add Sqmr variant to MessageSender with send logic

[sirandreww-starkware]

Note

Low Risk
Changes are confined to benchmark/test harness code and primarily add an alternate send path with basic error logging; minimal impact on production logic.

Overview
Extends the broadcast stress-test node MessageSender with a new SQMR variant and send path using SqmrClientSender.

When using SQMR, send_message now issues a query via send_new_query, spawns a task to drain the response stream, and logs failures via tracing::error instead of panicking; protocol registration for SQMR remains todo!.

^{Written by Cursor Bugbot for commit a509ca5. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551 👈 (View in Graphite)
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

[cursor]

SQMR silently continues after send failure, inflating metrics

Medium Severity

The Gossipsub branch calls unwrap() on send failure (panicking), while the new Sqmr branch only logs the error and returns normally. Since the caller in send_stress_test_messages unconditionally increments BROADCAST_MESSAGE_COUNT and BROADCAST_MESSAGE_BYTES_SUM after send_message returns, failed SQMR sends are counted as successful, producing misleading benchmark results.

 

[cursor]

Unbounded task spawning per SQMR send in stress loop

Medium Severity

Each SQMR send_message call spawns a detached tokio::spawn task to drain responses. Since the caller loops on a heartbeat interval in send_stress_test_messages, this creates an unbounded number of concurrent tasks over time. If responses arrive slower than the send rate, tasks accumulate indefinitely, leading to resource exhaustion — a real risk in a stress test scenario.