apollo_network_benchmark: added network metrics to network manager

[sirandreww-starkware]

Note

Low Risk
Adds metrics wiring and two new gauges without changing networking behavior or message flow; risk is limited to metric registration/collection correctness.

Overview
The broadcast network stress test node now initializes NetworkManager with a minimal NetworkMetrics instance, enabling collection of network-level metrics during runs.

This adds two new gauges (network_connected_peers, network_blacklisted_peers) and a helper (create_network_metrics) that wires them into the manager while leaving other network metric groups unset (None).

^{Written by Cursor Bugbot for commit f546ac1. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544 👈 (View in Graphite)
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

New network metrics not registered in register_metrics

Medium Severity

The newly added NETWORK_CONNECTED_PEERS and NETWORK_BLACKLISTED_PEERS gauge metrics are defined and passed to the NetworkManager via create_network_metrics(), but register_metrics() was not updated to call .register() on them. Every other metric follows this pattern. Without registration, these metrics won't be exported by the Prometheus exporter, making the new network metrics silently invisible.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/metrics.rs#L20-L22

 

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

New network metrics not registered in register_metrics

Medium Severity

The newly added NETWORK_CONNECTED_PEERS and NETWORK_BLACKLISTED_PEERS gauge metrics are defined in the define_metrics! macro and used in create_network_metrics(), but register_metrics() was not updated to call .register() on them. Every other metric in this file has a corresponding .register() call. Without registration, these metrics won't be exported or visible in monitoring.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/metrics.rs#L20-L22