apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum

[sirandreww-starkware]

Note

Medium Risk
Low code churn, but it introduces a new user-selectable mode that will crash at runtime (todo!()) if chosen.

Overview
Adds a new NetworkProtocol::ReveresedSqmr CLI-selectable variant (--network-protocol reversed-sqmr) for the network benchmark.

Updates register_protocol_channels to handle this variant, but currently calls todo!() with a placeholder comment instead of registering channels, so selecting it will panic at runtime.

^{Written by Cursor Bugbot for commit 50dae42. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553 👈 (View in Graphite)
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

New protocol option panics at runtime

Medium Severity

NetworkProtocol::ReveresedSqmr is exposed as a selectable CLI value in node_args.rs, but register_protocol_channels handles it with todo!(). Choosing reversed-sqmr causes an immediate panic during node initialization, so the newly advertised protocol mode is not runnable.

Additional Locations (1)

• crates/apollo_network_benchmark/src/node_args.rs#L23-L26

 

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

Misspelled enum variant affects serde serialization name

Medium Severity

The variant ReveresedSqmr is misspelled (should be ReversedSqmr — the 'e' and 's' are transposed). Because NetworkProtocol derives Serialize and Deserialize, serde will use the misspelled name ReveresedSqmr as the serialized representation. The clap #[value(name = "reversed-sqmr")] and the doc comment both use the correct spelling, creating an inconsistency where the CLI accepts the right name but serde uses the wrong one.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/protocol.rs#L64-L68