apollo_network_benchmark: add MessageIndexTracker struct

[sirandreww-starkware]

Note

Low Risk
Adds an unused helper module with no behavior changes to the running stress test node.

Overview
Introduces a new message_index_detector module in the broadcast network stress test node containing MessageIndexTracker, which tracks min/max seen message indices and computes an estimated count of missing (pending) messages.

main.rs is updated to include the new module, but the tracker is not yet wired into message handling (dead-code allowed).

^{Written by Cursor Bugbot for commit b32f987. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556 👈 (View in Graphite)
• apollo_network_benchmark: add ReversedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReversedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReversedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Duplicate indices break pending count

Low Severity

pending_messages_count() assumes every seen_message() call is a unique index. Because seen_messages_count increments on duplicates, max - min + 1 - seen_messages_count can go negative and underflow as u64, producing an incorrect huge pending value (or debug overflow panic) in message_index_detector.rs.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/message_index_detector.rs#L12-L13

 

[cursor]

New tracker code is currently unused

Low Severity

message_index_detector is added to the binary, but MessageIndexTracker, seen_message(), and pending_messages_count() are not referenced anywhere else. The file also suppresses this with #![allow(dead_code)], which leaves dead code in production and increases maintenance risk.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/message_index_detector.rs#L1-L31

 

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

Module name mismatches struct name semantically

Low Severity

The module is named message_index_detector but the struct it contains is MessageIndexTracker. "Detector" and "tracker" have different semantics — a detector identifies something, a tracker follows state over time. The struct clearly tracks state, so the module name is misleading. The module name could be message_index_tracker to match.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/main.rs#L15-L16