Merged
Conversation
This was referenced Dec 22, 2025
Merged
agalasso
force-pushed
the
andy/code-cleanup-use-wxClip
branch
from
5f536bf to
6f10a27
Compare
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
f965bde to
853d2a3
Compare
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/code-cleanup-use-wxClip
branch
from
6f10a27 to
3376286
Compare
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
853d2a3 to
ec2dda0
Compare
agalasso
force-pushed
the
andy/code-cleanup-use-wxClip
branch
from
3376286 to
ac4691c
Compare
Remove some unnecessary null checks for Guider::CurrentImage(). Although the checks are harmless, they make the code a bit harder to understand as readers may be wondering about how or why the current image could be null (it cannot!).
agalasso
force-pushed
the
andy/guider-CurrentImage-is-never-null
branch
from
ec2dda0 to
51b54b8
Compare
Eyeke2
pushed a commit
to Eyeke2/phd2.planetary
that referenced
this pull request
Mar 6, 2026
Remove some unnecessary null checks for Guider::CurrentImage(). Although the checks are harmless, they make the code a bit harder to understand as readers may be wondering about how or why the current image could be null (it cannot!).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guider's CurrentImage is never null
Remove some unnecessary null checks for Guider::CurrentImage().
Although the checks are harmless, they make the code a bit harder
to understand as readers may be wondering about how or why the
current image could be null (it cannot!).