Merged
Conversation
This was referenced Dec 22, 2025
Merged
agalasso
force-pushed
the
andy/camera-Binning-rename-to-HwBinning
branch
from
e05a935 to
fd57c0a
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
4404d0e to
8e4b36b
Compare
agalasso
force-pushed
the
andy/camera-Binning-rename-to-HwBinning
branch
from
fd57c0a to
fd2f6c7
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
8e4b36b to
b352397
Compare
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/camera-Binning-rename-to-HwBinning
branch
from
fd2f6c7 to
fdb4daa
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
b352397 to
20bfb95
Compare
agalasso
force-pushed
the
andy/camera-Binning-rename-to-HwBinning
branch
from
fdb4daa to
e3feb99
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
20bfb95 to
6cd49c7
Compare
agalasso
force-pushed
the
andy/camera-Binning-rename-to-HwBinning
branch
from
e3feb99 to
0ed3d64
Compare
Base automatically changed from
andy/camera-Binning-rename-to-HwBinning
to
master
December 31, 2025 22:08
Move the "has Bayer" property from GuideCamera child classes up to the parent class. This will allow moving the image post-processing up to the parent class as well in a following PR. No functional changes, just adding the property to the parent class and replacing the child class member variables with the member from the parent class.
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
6cd49c7 to
7c0825d
Compare
Eyeke2
pushed a commit
to Eyeke2/phd2.planetary
that referenced
this pull request
Mar 6, 2026
Move the "has Bayer" property from GuideCamera child classes up to the parent class. This will allow moving the image post-processing up to the parent class as well in a following PR. No functional changes, just adding the property to the parent class and replacing the child class member variables with the member from the parent class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuideCamera HasBayer property
Move the "has Bayer" property from GuideCamera child classes up to the parent class.
This will allow moving the image post-processing up to the parent class as
well in a following PR.
No functional changes, just adding the property to the parent class
and replacing the child class member variables with the member from
the parent class.