code cleanup: remove unneeded subframe check for single_exposure#1405
Merged
code cleanup: remove unneeded subframe check for single_exposure#1405
Conversation
This was referenced Dec 22, 2025
Merged
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
4404d0e to
8e4b36b
Compare
agalasso
force-pushed
the
andy/remove-unneed-subframe-check
branch
from
b0f7e1b to
2263cc9
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
8e4b36b to
b352397
Compare
agalasso
force-pushed
the
andy/remove-unneed-subframe-check
branch
from
2263cc9 to
c84dd7c
Compare
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
b352397 to
20bfb95
Compare
agalasso
force-pushed
the
andy/remove-unneed-subframe-check
branch
from
c84dd7c to
ea0c80b
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
20bfb95 to
6cd49c7
Compare
agalasso
force-pushed
the
andy/remove-unneed-subframe-check
branch
from
ea0c80b to
8c49751
Compare
agalasso
force-pushed
the
andy/GuideCamera-HasBayer-member-variable
branch
from
6cd49c7 to
7c0825d
Compare
Base automatically changed from
andy/GuideCamera-HasBayer-member-variable
to
master
December 31, 2025 22:08
Remove an unneeded subframe check in the server get_single_exposure code path. The subframe is already validated in Capture().
agalasso
force-pushed
the
andy/remove-unneed-subframe-check
branch
from
8c49751 to
fcfb7d7
Compare
Eyeke2
pushed a commit
to Eyeke2/phd2.planetary
that referenced
this pull request
Mar 6, 2026
…nPHDGuiding#1405) Remove an unneeded subframe check in the server get_single_exposure code path. The subframe is already validated in Capture().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code cleanup: remove unneeded subframe check for single_exposure
Remove an unneeded subframe check in the server get_single_exposure
code path. The subframe is already validated in Capture().