Conversation
This was referenced Dec 22, 2025
agalasso
force-pushed
the
andy/cosmetic
branch
from
097fb5f to
0d5ca55
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
b14b68c to
513517a
Compare
agalasso
force-pushed
the
andy/cosmetic
branch
from
0d5ca55 to
2e6e4d3
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
513517a to
ffbc498
Compare
agalasso
force-pushed
the
andy/cosmetic
branch
from
2e6e4d3 to
2f44af5
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
ffbc498 to
a568ae7
Compare
bwdev01
approved these changes
Dec 23, 2025
agalasso
force-pushed
the
andy/cosmetic
branch
from
2f44af5 to
7664dde
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
a568ae7 to
7e42e41
Compare
agalasso
force-pushed
the
andy/cosmetic
branch
from
7664dde to
13ec2eb
Compare
agalasso
force-pushed
the
andy/unreachable-code
branch
from
7e42e41 to
cc12873
Compare
agalasso
force-pushed
the
andy/cosmetic
branch
from
13ec2eb to
ac31cd0
Compare
m_binning is never null on this code path.
agalasso
force-pushed
the
andy/unreachable-code
branch
from
cc12873 to
f6a0780
Compare
Eyeke2
pushed a commit
to Eyeke2/phd2.planetary
that referenced
this pull request
Mar 6, 2026
m_binning is never null on this code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unreachable code
m_binning is never null on this code path.