Conversation
bwdev01
approved these changes
Dec 24, 2025
agalasso
force-pushed
the
andy/software-binning-support
branch
from
778d4b7 to
4ccec25
Compare
agalasso
force-pushed
the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
from
bd2246a to
8907556
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
4ccec25 to
47e5cb4
Compare
agalasso
force-pushed
the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
from
8907556 to
2e7486a
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
47e5cb4 to
8013c33
Compare
agalasso
force-pushed
the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
from
2e7486a to
2415daf
Compare
Merged
agalasso
force-pushed
the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
from
b108152 to
2415daf
Compare
agalasso
force-pushed
the
andy/software-binning-support
branch
from
8013c33 to
5704847
Compare
CameraConfigDialogCtrlSet::m_binning is initialized in the constructor and is never null. Small code simplification removing the null checks.
agalasso
force-pushed
the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
from
2415daf to
6c97918
Compare
agalasso
deleted the
andy/remove-unneeded-null-checks-CameraConfigDialogCtrlSet-m_binning
branch
Eyeke2
pushed a commit
to Eyeke2/phd2.planetary
that referenced
this pull request
Mar 6, 2026
…ng (OpenPHDGuiding#1420) CameraConfigDialogCtrlSet::m_binning is initialized in the constructor and is never null. Small code simplification removing the null checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded null checks around CameraConfigDialogCtrlSet::m_binning
CameraConfigDialogCtrlSet::m_binning is initialized in the constructor and is
never null.
Small code simplification removing the null checks.