WIP: batched minor cleanups and editorial touchups#2203
Draft
jonatack wants to merge 7 commits into
Draft
Conversation
This was referenced Jun 26, 2026
jonatack
force-pushed
the
2026-04-batched-cleanups
branch
from
df42686 to
3d09f05
Compare
Credit to forkfury for pointing out the incomplete sentence in bitcoin#2027. Co-authored-by: forkfury <forkfury@gmail.com>
jonatack
force-pushed
the
2026-04-batched-cleanups
branch
from
3d09f05 to
ca43ebd
Compare
jonatack
changed the title
| ;Libbitcoinconsensus | ||
| : the existing implementation is a library that is compiled by default with Bitcoin Core master and exposes a single C function named bitcoinconsensus_verify_script(). Although it has a deterministic build and implements the most complex rules (most of the cryptography, which is itself heavily based on libsecp256k1 after #REPLACE_libsecp256k1_PR), it is still not a complete specification of the consensus rules. Since libconsensus doesn't manage the current state but only the validation of the next block given that state, it is known that this long effort of encapsulation and decoupling will eventually finish, and that the person who moves the last line | ||
| [BIP Editors' note: (a) the last sentence was left incomplete by the BIP author, and (b) the libbitcoin-consensus library was deprecated in Bitcoin Core v27.0 and was completely removed in v28.0; see https://github.com/bitcoin/bitcoin/pull/29189 and https://github.com/bitcoin/bitcoin/pull/29648] |
Member
There was a problem hiding this comment.
This formats the note as a link. You could instead use HTML entities:
Suggested change
| [BIP Editors' note: (a) the last sentence was left incomplete by the BIP author, and (b) the libbitcoin-consensus library was deprecated in Bitcoin Core v27.0 and was completely removed in v28.0; see https://github.com/bitcoin/bitcoin/pull/29189 and https://github.com/bitcoin/bitcoin/pull/29648] | |
| [BIP Editors' note: (a) the last sentence was left incomplete by the BIP author, and (b) the libbitcoin-consensus library was deprecated in Bitcoin Core v27.0 and was completely removed in v28.0; see https://github.com/bitcoin/bitcoin/pull/29189 and https://github.com/bitcoin/bitcoin/pull/29648] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.