BIP340: Remove unused hash_sha256 helper#2031
Closed
MozirDmitriy wants to merge 1 commit into
Closed
Conversation
jonatack
reviewed
Nov 4, 2025
jonatack
left a comment
jonatack
left a comment
Member
There was a problem hiding this comment.
ACK
We'll batch this into a monthly cleanup that will credit you as author (thanks!)
Member
Done in #2203 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted an unused SHA-256 wrapper (hash_sha256) that was not referenced anywhere in the codebase.
The implementation relies on tagged_hash and direct hashlib.sha256 calls