Closed
Conversation
mkdirs()IO catch on mkdirs()
Contributor
Author
|
is this any good? |
elharo
reviewed
May 27, 2025
Contributor
elharo
left a comment
There was a problem hiding this comment.
Thanks. Most comments are the same across the files
...aven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java
Show resolved
Hide resolved
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...in-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java
Outdated
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...tubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java
Outdated
Show resolved
Hide resolved
...re-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java
Outdated
Show resolved
Hide resolved
...-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
Show resolved
Hide resolved
dd3aa4d to
c642b8b
Compare
Pankraz76
commented
May 27, 2025
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
Contributor
Author
c642b8b to
469a8e6
Compare
elharo
requested changes
May 28, 2025
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java
Show resolved
Hide resolved
This was referenced May 28, 2025
469a8e6 to
6502d96
Compare
gnodet
requested changes
Jun 3, 2025
Contributor
gnodet
left a comment
There was a problem hiding this comment.
I see no benefit in this change.
Contributor
Author
|
its simply false catch and hindering will give dedicated example. But yes it should be done in combination with |
Contributor
Author
indeed, not all, as its a mix of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

AbstractMojo#createFile(File)#2395