try can use automatic resource management 1/2

[Pankraz76]

after merging this, they will become one:

• chore: singularize AbstractMojo#createFile(File) #2395
• avoid false IO catch on mkdirs() #2396

@elharo

[Pankraz76]

again NPE:

Error:  Errors: 
Error:    MavenIT0008SimplePluginTest.testit0008:45 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0010DependencyClosureResolutionTest.testit0010:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0011DefaultVersionByDependencyManagementTest.testit0011:44 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0018DependencyManagementTest.testit0018:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0021PomProfileTest.testit0021:42 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0030DepPomDepMgmtInheritanceTest.testit0030:40 » NullPointer Cannot invoke "java.io.File.exists()" because "dir" is null
Error:    MavenIT0041ArtifactTypeFromPluginExtensionTest.testit0041:47 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0085TransitiveSystemScopeTest.testit0085:48 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0087PluginRealmWithProjectLevelDepsTest.testit0087:53 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0142DirectDependencyScopesTest.testit0142:56 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitCompileScope:53->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitProvidedScope:113->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitRuntimeScope:162->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0143TransitiveDependencyScopesTest.testitTestScope:211->run:249 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitNonTimestampedNameWithInstalledSNAPSHOT:102 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenIT0146InstallerSnapshotNaming.testitRemoteDownloadTimestampedName:86 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0377PluginLookupFromPrefixTest.testitMNG377:49 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
Error:    MavenITmng0461TolerateMissingDependencyPomTest.testit:51 » NullPointer Cannot invoke "java.nio.file.Path.toFile()" because "dir" is null
[INFO] 
Error:  Tests run: 978, Failures: 0, Errors: 18, Skipped: 49
[INFO] 

[Pankraz76]

interesting, will give SOC to isolate error.

[Pankraz76]

dedicate in PR to fix API.

[Pankraz76]

build success assuming new flaky test failing on main as well:

MavenExecutorTestSupport.version:125

[Pankraz76]

lets get this.

[Pankraz76]

items:

Error:  Failures: 
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: <true> but was: <false>
Error:    ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was: <unknown>
[INFO] 
Error:  Tests run: 54, Failures: 4, Errors: 0, Skipped: 5

[Pankraz76]

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this one failing on main for me as well.

[Pankraz76]

item:
[INFO] Results:
[INFO]
Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 54, Failures: 4, Errors: 0, Skipped: 5
[INFO]

[Pankraz76]

Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:

this seems flaky. Locally everything´s fine.

[Pankraz76]

lets see if separation is enough to isolate issue.

[Pankraz76]

lets make this 1o1, its persistent issue:

Error: Failures:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutput:168 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedColor:186 No ANSI codes present ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.defaultFsCaptureOutputWithForcedOffColor:206 No INFO found ==> expected: but was:
Error: ForkedMavenExecutorTest>MavenExecutorTestSupport.version:124 expected: <4.0.0-rc-4-SNAPSHOT> but was:
[INFO]
Error: Tests run: 5

[Pankraz76]

need to give this dedication

• use try-with-resources statement in CatchMojo #2424