chore: singularize `AbstractMojo#createFile(File)` by Pankraz76 · Pull Request #2395 · apache/maven

Pankraz76 · 2025-05-27T10:43:01Z

22 times the same code:

...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java

Pankraz76

checked: https://docs.oracle.com/javase/8/docs/api/java/io/IOException.html

We shouldn’t write code like it’s an ATM—it’s confusing, mimics structure without real purpose, and avoids modern patterns. This approach trades boilerplate for actual business functionality.

...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java

its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java

...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java

Pankraz76 · 2025-05-27T20:31:00Z

wait for enabler.

avoid false IO catch on mkdirs() #2396

elharo

I usually skip Draft PRs. When you're happy with it, mark it ready for review.

compat/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java

...en-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java

.../src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java

elharo

In order to avoid wasting time:

Move PRs out of draft before requesting feedback. Don't ask for review until you think your PR is ready to merge.
Don't send the same changes in multiple PRs. Stack the branches or wait for the first PR to be merged or closed first.

Pankraz76 · 2025-06-09T12:35:45Z

@slachiewicz kindly request your review.

...plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java

Pankraz76 · 2025-06-09T13:09:54Z

no just wanted to check ci results but push does reset of course.

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java

...support/core-it-component/src/main/java/org/apache/maven/coreit/component/MojoCompanion.java

Pankraz76 · 2025-06-09T21:22:53Z

its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/pom.xml

+  <dependencies>
+    <dependency>
+      <groupId>org.apache.maven.its</groupId>
+      <artifactId>core-it-component</artifactId>


need exception type MojoExecutionException

Pankraz76 closed this May 27, 2025

Pankraz76 reopened this May 27, 2025

Pankraz76 force-pushed the can-use-automatic-resource-management- branch 2 times, most recently from 2b1a621 to 92c8a5e Compare May 27, 2025 10:52

Pankraz76 commented May 27, 2025

View reviewed changes

...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java Show resolved Hide resolved

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 92c8a5e to 67c3363 Compare May 27, 2025 10:59

Pankraz76 commented May 27, 2025

View reviewed changes

...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java Outdated Show resolved Hide resolved

Pankraz76 marked this pull request as ready for review May 27, 2025 11:05

Pankraz76 force-pushed the can-use-automatic-resource-management- branch 2 times, most recently from e99e668 to 5355f71 Compare May 27, 2025 11:07

Pankraz76 commented May 27, 2025

View reviewed changes

its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java Show resolved Hide resolved

Pankraz76 mentioned this pull request May 27, 2025

avoid false IO catch on mkdirs() #2396

Closed

elharo reviewed May 27, 2025

View reviewed changes

...s/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java Show resolved Hide resolved

Pankraz76 changed the title ~~try can use automatic resource management~~ try can use automatic resource management May 27, 2025

Pankraz76 mentioned this pull request May 27, 2025

[POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone #2364

Closed

Pankraz76 marked this pull request as draft May 27, 2025 20:30

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 5355f71 to eec11b0 Compare May 28, 2025 09:07

elharo reviewed May 28, 2025

View reviewed changes

Pankraz76 changed the title ~~try can use automatic resource management~~ try can use automatic resource management - all May 28, 2025

Pankraz76 mentioned this pull request May 28, 2025

try can use automatic resource management 1/2 #2401

Closed

Pankraz76 commented May 31, 2025

View reviewed changes

compat/maven-model-builder/src/main/java/org/apache/maven/model/building/ModelProblemUtils.java Show resolved Hide resolved

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from e487cb3 to a1b6bab Compare May 31, 2025 09:44

Pankraz76 commented May 31, 2025

View reviewed changes

...en-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java Show resolved Hide resolved

elharo requested changes May 31, 2025

View reviewed changes

...en-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java Show resolved Hide resolved

...en-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java Outdated Show resolved Hide resolved

Pankraz76 mentioned this pull request May 31, 2025

abstract implicit used API MavenInvoker#customizeSettingsRequest #2406

Closed

9 tasks

Pankraz76 commented May 31, 2025

View reviewed changes

.../src/main/java/org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java Show resolved Hide resolved

Pankraz76 changed the title ~~try can use automatic resource management - all~~ Add method AbstractMojo#mkDirForParentFile(File) to fix try can use automatic resource management May 31, 2025

Pankraz76 changed the title ~~Add method AbstractMojo#mkDirForParentFile(File) to fix try can use automatic resource management~~ Add method AbstractMojo#mkDirForParentFile(File) central fix try can use automatic resource management Jun 1, 2025

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from d0a49a5 to 00778d6 Compare June 1, 2025 15:54

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 0dec76d to eb54fda Compare June 1, 2025 16:10

elharo reviewed Jun 1, 2025

View reviewed changes

Pankraz76 force-pushed the can-use-automatic-resource-management- branch 2 times, most recently from 1c0877c to 3288488 Compare June 3, 2025 16:47

Pankraz76 mentioned this pull request Jun 3, 2025

use try-with-resources statement in LookupWagonMojo #2426

Merged

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 3288488 to d7adc15 Compare June 9, 2025 12:27

Pankraz76 changed the title ~~Add method AbstractMojo#mkDirForParentFile(File) central fix try can use automatic resource management~~ chore: centralize AbstractMojo#createNewFile(File) using try-with-resource statement Jun 9, 2025

Pankraz76 changed the title ~~chore: centralize AbstractMojo#createNewFile(File) using try-with-resource statement~~ chore: centralize AbstractMojo#createNewFile(File) Jun 9, 2025

Pankraz76 changed the title ~~chore: centralize AbstractMojo#createNewFile(File)~~ chore: centralize AbstractMojo#createFile(File) Jun 9, 2025

Pankraz76 changed the title ~~chore: centralize AbstractMojo#createFile(File)~~ chore: apply SOC to give single AbstractMojo#createFile(File) Jun 9, 2025

Pankraz76 changed the title ~~chore: apply SOC to give single AbstractMojo#createFile(File)~~ chore: apply SOC to have single AbstractMojo#createFile(File) Jun 9, 2025

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from d7adc15 to 9ae5c5e Compare June 9, 2025 12:34

Pankraz76 marked this pull request as ready for review June 9, 2025 12:34

Pankraz76 requested a review from elharo June 9, 2025 12:34

Pankraz76 changed the title ~~chore: apply SOC to have single AbstractMojo#createFile(File)~~ chore: promote central AbstractMojo#createFile(File) Jun 9, 2025

Pankraz76 commented Jun 9, 2025

View reviewed changes

...plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java Show resolved Hide resolved

elharo requested changes Jun 9, 2025

View reviewed changes

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java Outdated Show resolved Hide resolved

Pankraz76 changed the title ~~chore: promote central AbstractMojo#createFile(File)~~ chore: singularize AbstractMojo#createFile(File) Jun 9, 2025

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 9ae5c5e to ed24be1 Compare June 9, 2025 13:09

Pankraz76 requested a review from elharo June 9, 2025 13:10

elharo requested changes Jun 9, 2025

View reviewed changes

compat/maven-plugin-api/src/main/java/org/apache/maven/plugin/AbstractMojo.java Outdated Show resolved Hide resolved

...support/core-it-component/src/main/java/org/apache/maven/coreit/component/MojoCompanion.java Outdated Show resolved Hide resolved

Pankraz76 mentioned this pull request Jun 9, 2025

use try-with-resources statement in Mojos #2443

Closed

9 tasks

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from ed24be1 to 4a9dc23 Compare June 9, 2025 21:21

chore: singularize AbstractMojo#createFile(File)

6c1fbe8

Pankraz76 force-pushed the can-use-automatic-resource-management- branch from 4a9dc23 to 6c1fbe8 Compare June 9, 2025 21:22

Pankraz76 commented Jun 9, 2025

View reviewed changes

Pankraz76 requested a review from elharo June 9, 2025 21:23

slachiewicz closed this Jun 9, 2025

Conversation

Pankraz76 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Pankraz76 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

Pankraz76 commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

Pankraz76 Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pankraz76 commented May 27, 2025 •

edited

Loading

Pankraz76 left a comment •

edited

Loading

Pankraz76 commented May 27, 2025 •

edited

Loading