[POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone

[Pankraz76]

Error prone, which is default, only exposes 3 issues, which seem to have real impact:

• chore: drop obsolete DefaultXmlService#findNodeById #2334
• chore: AbstractDependencyMojo PMD-Rule: EmptyControlStatement #2368

Issues:

• chore: add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2367
• chore: fix unused @SuppressWarnings("checkstyle:UnusedLocalVariable") #2366
• add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2365
• chore: resolve false negative suppression @SuppressWarnings("checkstyle:UnusedLocalVariable") #2369

Best practices impacts on code shape.

• [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Best practices #2331

[Pankraz76]

wip

[Pankraz76]

• chore: drop obsolete DefaultXmlService#findNodeById #2334

[slachiewicz]

Too big a list of pmd exclusions.

Please avoid opening PR if You see lots of planned updates, to avoid noise and unnecessary notifications.
Check if Your build is green before opening PR.

Thank you for understanding

[Pankraz76]

avoid noise and unnecessary notifications

why cant we apply this valuable pattern inside the code too?

true ? false
is the logically same like
((true) ? (((false)))))

which one seems simpler?

• https://docs.openrewrite.org/recipes/staticanalysis/simplifyconstantifbranchexecution
• https://sonarsource.github.io/rspec/#/rspec/S1110
• https://sonarsource.github.io/rspec/#/rspec/S1611

what a coincidence that all languages agree upon the same:

[Pankraz76]

• chore: singularize AbstractMojo#createFile(File) #2395
• https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#usetrywithresources

[Pankraz76]

• avoid false IO catch on mkdirs() #2396
• avoid false IO catch on mkdirs() #2396 (review)
• https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation
• https://pmd.sourceforge.io/pmd-6.3.0/pmd_rules_java_bestpractices.html#missingoverride

[Pankraz76]

• 2bbaf16
• https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#avoidreassigningparameters

[Pankraz76]

• Fix 'string builder buffer' can be replaced with 'string'  #2415

[Pankraz76]

• [java] New Rule: VariableCanBeInlined: Local variables should not be declared and then immediately returned or thrown pmd/pmd#5770
• Fix 'string builder buffer' can be replaced with 'string'  #2415
• https://github.com/apache/maven/pull/2415/files#r2117688353

[Pankraz76]

• fix: emptyControlStatement in DefaultModelInterpolator #2373
• https://github.com/apache/maven/pull/2373/files#r2131936501
• https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#unusedassignment
• https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#unusedformalparameter

[Pankraz76]

• https://github.com/apache/maven/pull/2373/files#r2131963449
• [java] AvoidCatchingRawExceptionTypes pmd/pmd#5801

[Pankraz76]

• use try-with-resources statement in Mojos #2443 (comment)
• use try-with-resources statement in Mojos #2443