Skip to content

remove buyer change in web#290

Open
kiftio wants to merge 1 commit into
json-rpc-typing/android-typed-paramsfrom
06-16-remove_buyer_change_in_web
Open

remove buyer change in web#290
kiftio wants to merge 1 commit into
json-rpc-typing/android-typed-paramsfrom
06-16-remove_buyer_change_in_web

Conversation

@kiftio

@kiftio kiftio commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

It looks like we intentionally removed this from native - so this is aimed at parity. Totally fine to go the otherway and introduce to native though.


Removes the checkout:buyerChange event (ec.buyer.change protocol message) from the web platform. This includes removing the event class (ShopifyCheckoutBuyerChangeEvent), its associated detail interface (ShopifyCheckoutBuyerChangeEventDetail), the typed addEventListener overload, the protocol message handler, and all related type definitions (CheckoutBuyerChangeEvent, CheckoutProtocolMessageMap["ec.buyer.change"]). The event is also removed from the public exports, the sample app event list, and the README documentation.

The test suite is updated to verify that ec.buyer.change is now treated as an unsupported/ignored notification alongside other unknown methods.

How to test

  1. Run the existing test suite: pnpm test in platforms/web.
  2. Confirm that the "ignores unsupported notification" test now covers both "customMethod" and "ec.buyer.change".
  3. Confirm that no checkout:buyerChange events are dispatched or exported by the package.
  4. Verify the sample app no longer lists checkout:buyerChange as a subscribable event type.

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

This was referenced Jun 16, 2026

kiftio commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kiftio kiftio mentioned this pull request Jun 16, 2026
11 tasks
@kiftio kiftio force-pushed the 06-16-respond_to_unknown_requests_with_error branch from b19959a to d9a76f4 Compare June 16, 2026 12:48
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 5f40f17 to 0af9fa1 Compare June 16, 2026 12:48
@kiftio kiftio force-pushed the 06-16-respond_to_unknown_requests_with_error branch from d9a76f4 to 7adc030 Compare June 16, 2026 19:44
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 0af9fa1 to 1c274f9 Compare June 16, 2026 19:44
@kiftio kiftio marked this pull request as ready for review June 16, 2026 20:09
@kiftio kiftio requested a review from a team as a code owner June 16, 2026 20:09
@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 99%
98.5% (263/267) 88.48% (146/165) 100% (58/58)

Copy link
Copy Markdown
Contributor

image.png

Buyer change exists in the CheckoutProtocol - not public, but should we go through with removing there till we decide to support?

@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 1c274f9 to 0ca4dae Compare June 18, 2026 09:06
@kiftio kiftio force-pushed the 06-16-respond_to_unknown_requests_with_error branch from 7adc030 to 0b3a610 Compare June 18, 2026 09:06
@markmur

markmur commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify yeah agree that we should just strip this from the protocol everywhere until we decide to add it. I'll open a PR for this today

@kiftio kiftio force-pushed the 06-16-respond_to_unknown_requests_with_error branch 2 times, most recently from a425af4 to be24079 Compare June 18, 2026 10:06
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch 2 times, most recently from af4701b to d611908 Compare June 18, 2026 11:12
@kiftio kiftio force-pushed the 06-16-respond_to_unknown_requests_with_error branch from be24079 to 61965cf Compare June 18, 2026 11:12
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kiftio kiftio changed the base branch from 06-16-respond_to_unknown_requests_with_error to graphite-base/290 June 18, 2026 13:59
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from d611908 to 49334a2 Compare June 18, 2026 13:59
@kiftio kiftio force-pushed the graphite-base/290 branch from 61965cf to 2e4191a Compare June 18, 2026 13:59
@kiftio kiftio changed the base branch from graphite-base/290 to json-rpc-typing/android-typed-params June 18, 2026 14:00
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 49334a2 to db8403f Compare June 18, 2026 14:15
@kiftio kiftio force-pushed the json-rpc-typing/android-typed-params branch 2 times, most recently from 8b22ab3 to 80de055 Compare June 18, 2026 14:54
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch 2 times, most recently from 46a8945 to a604c76 Compare June 18, 2026 15:01
@kiftio kiftio force-pushed the json-rpc-typing/android-typed-params branch from 80de055 to 1d0dac2 Compare June 18, 2026 15:01
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from a604c76 to 2d29352 Compare June 18, 2026 15:23
@kiftio kiftio force-pushed the json-rpc-typing/android-typed-params branch 2 times, most recently from 1f5c3e9 to 23452c0 Compare June 18, 2026 15:45
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 2d29352 to 74119ca Compare June 18, 2026 15:45
@kiftio kiftio force-pushed the json-rpc-typing/android-typed-params branch 2 times, most recently from 328328c to ff74818 Compare June 18, 2026 20:03
@kiftio kiftio force-pushed the 06-16-remove_buyer_change_in_web branch from 74119ca to 5e62692 Compare June 18, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants