remove buyer change in web#290
Open
kiftio wants to merge 1 commit into
Open
Conversation
This was referenced Jun 16, 2026
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
b19959a to
d9a76f4
Compare
5f40f17 to
0af9fa1
Compare
d9a76f4 to
7adc030
Compare
0af9fa1 to
1c274f9
Compare
markmur
approved these changes
Jun 17, 2026
kieran-osgood-shopify
approved these changes
Jun 17, 2026
Contributor
1c274f9 to
0ca4dae
Compare
7adc030 to
0b3a610
Compare
Contributor
|
@kieran-osgood-shopify yeah agree that we should just strip this from the protocol everywhere until we decide to add it. I'll open a PR for this today |
a425af4 to
be24079
Compare
af4701b to
d611908
Compare
be24079 to
61965cf
Compare
d611908 to
49334a2
Compare
61965cf to
2e4191a
Compare
This was referenced Jun 18, 2026
49334a2 to
db8403f
Compare
8b22ab3 to
80de055
Compare
46a8945 to
a604c76
Compare
80de055 to
1d0dac2
Compare
a604c76 to
2d29352
Compare
1f5c3e9 to
23452c0
Compare
2d29352 to
74119ca
Compare
328328c to
ff74818
Compare
74119ca to
5e62692
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What changes are you making?
It looks like we intentionally removed this from native - so this is aimed at parity. Totally fine to go the otherway and introduce to native though.
Removes the
checkout:buyerChangeevent (ec.buyer.changeprotocol message) from the web platform. This includes removing the event class (ShopifyCheckoutBuyerChangeEvent), its associated detail interface (ShopifyCheckoutBuyerChangeEventDetail), the typedaddEventListeneroverload, the protocol message handler, and all related type definitions (CheckoutBuyerChangeEvent,CheckoutProtocolMessageMap["ec.buyer.change"]). The event is also removed from the public exports, the sample app event list, and the README documentation.The test suite is updated to verify that
ec.buyer.changeis now treated as an unsupported/ignored notification alongside other unknown methods.How to test
pnpm testinplatforms/web."ignores unsupported notification"test now covers both"customMethod"and"ec.buyer.change".checkout:buyerChangeevents are dispatched or exported by the package.checkout:buyerChangeas a subscribable event type.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.