respond to unknown requests with error#289
Open
kiftio wants to merge 1 commit into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
Merged
5f3a339 to
57049b1
Compare
129ae8e to
b19959a
Compare
57049b1 to
2d9284e
Compare
b19959a to
d9a76f4
Compare
2d9284e to
98a13f0
Compare
d9a76f4 to
7adc030
Compare
98a13f0 to
4b0d021
Compare
Contributor
|
Soft non-blocking notes, mostly for consistency with the protocol spec:
Keeping these soft because I do not think they need to block this PR. |
tiagocandido
approved these changes
Jun 17, 2026
tiagocandido
left a comment
Contributor
There was a problem hiding this comment.
Approved. Left a few soft non-blocking notes for protocol consistency.
4b0d021 to
e711cb0
Compare
7adc030 to
0b3a610
Compare
0b3a610 to
a425af4
Compare
e711cb0 to
86e9f2e
Compare
be24079 to
61965cf
Compare
61965cf to
ff31aa5
Compare
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
When the checkout bridge receives a JSON-RPC request for an unsupported or unknown method, it now returns a proper JSON-RPC error response with code
-32601("Method not found") instead of silently ignoring it. This applies across all three platforms (Android, Swift, and Web).The distinction between requests (messages with an
idfield) and notifications (messages without anidfield) is now respected per the JSON-RPC spec: only requests receive an error response, while notifications continue to be silently ignored.How to test
idfield (e.g.{"jsonrpc":"2.0","method":"ec.auth","id":"1","params":{}}) through the checkout bridge on any platform."code": -32601and"message": "Method not found", with the matchingid.idfield (e.g.{"jsonrpc":"2.0","method":"ec.auth","params":{}}).Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.