hide communication client#288
Draft
kiftio wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 16, 2026
Merged
7156a26 to
b2500fb
Compare
5f3a339 to
57049b1
Compare
b2500fb to
b61158a
Compare
57049b1 to
2d9284e
Compare
2d9284e to
98a13f0
Compare
b61158a to
4b0d021
Compare
98a13f0 to
9229144
Compare
9229144 to
ee2237f
Compare
0ca4dae to
af4701b
Compare
ee2237f to
9466b3f
Compare
af4701b to
d611908
Compare
9466b3f to
aa6d082
Compare
d611908 to
49334a2
Compare
aa6d082 to
0481a57
Compare
This was referenced Jun 18, 2026
49334a2 to
db8403f
Compare
0481a57 to
a5f73e9
Compare
db8403f to
46a8945
Compare
a5f73e9 to
09d712f
Compare
46a8945 to
a604c76
Compare
09d712f to
3fafc47
Compare
3fafc47 to
ea6a28a
Compare
a604c76 to
2d29352
Compare
ea6a28a to
ed5d329
Compare
74119ca to
5e62692
Compare
ed5d329 to
0bfc1d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
PR 2 - make the process method internal.
CheckoutCommunicationClient(Android) andCheckoutCommunicationProtocol(Swift/iOS) were previously public-facing interfaces that merchants could implement directly. This PR narrows their visibility tointernal/package, makingCheckoutProtocol.Clientthe sole public API for connecting typed Embedded Checkout Protocol (ECP) handlers.On Android,
CheckoutProtocol.Clientno longer implementsCheckoutCommunicationClient. Instead, an internalCheckoutProtocolClientAdapterbridges between the two, and an extension functionasCommunicationClient()is used at the boundary where the internal interface is required. All public-facing APIs (ShopifyCheckoutKit.present,CheckoutPresentation.connect,CheckoutDialog,CheckoutWebView) now acceptCheckoutProtocol.Clientdirectly.On Swift/iOS,
CheckoutCommunicationProtocolis demoted topackagevisibility. The publicpresent(checkout:from:delegate:client:)function andCheckoutViewController.init,ShopifyCheckout.connect, andAcceleratedCheckoutButtons.connectnow acceptCheckoutProtocol.Clientdirectly. Apackage-scoped overload ofpresentandconnectretaining theany CheckoutCommunicationProtocolsignature is preserved for internal use (e.g. the React Native bridge). The CocoaPodsProtocolRelayretroactive conformance ofCheckoutProtocol.ClienttoCheckoutCommunicationProtocolis removed since it is no longer needed.How to test
CheckoutProtocol.ClienttoShopifyCheckoutKit.present(Android) andpresent(checkout:from:delegate:client:)(iOS) compiles and dispatches typed callbacks correctly.CheckoutCommunicationClient/CheckoutCommunicationProtocolimplementation directly to any public API no longer compiles.CheckoutPresentationTestandEmbeddedCheckoutProtocolTest, and verify they pass.ProtocolRelayTestsuite and confirm all tests pass using the reflection-basedprocessForTesthelper.package-scoped overloads.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.