Remove private buyerChange event from Swift and Kotlin protocol#295
Merged
Conversation
kieran-osgood-shopify
approved these changes
Jun 18, 2026
React Native — Coverage Report
|
Contributor
|
Hey, I was doing the same here -> https://app.graphite.com/github/pr/Shopify/checkout-kit/290/remove-buyer-change-in-web |
Contributor
Author
|
@kiftio yeah this is a follow up to the web removal - it removes it from Swift + Kotlin |
Contributor
|
I pushed an update to do the same.. But all good, let's merge and I'll resolve conflicts |
kiftio
approved these changes
Jun 18, 2026
Contributor
Author
|
@kiftio ah sorry didn't realise. Happy to close this and ship it in one PR? |
Contributor
|
no, let's merge 🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Removes the internal
buyerChangenotification descriptor (ec.buyer.change) from the native protocol layer — the SwiftShopifyCheckoutProtocolpackage and the Android SDK — plus its unit test in each.Unlike web (which exposed
checkout:buyerChangepublicly), native never surfaced this event:internal valin Kotlin, default-internalstatic letin Swift. This drops the dead descriptor for parity with the web removal in #290.Native-only: does not touch the OpenRPC wire schema (
ec.buyer.changestays defined inembedded.openrpc.json) or the generated TypeScript. The native descriptors are hand-written, so they don't track the schema.Related: #290 (web).