feat(redirect): add wildcard redirect support; spin sdk bump; CI test additions#12
Conversation
…ect support Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Adam Reese <adam@reese.io>
|
Will add tests to |
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
wildcard-redirects
branch
from
7bc798c to
0b1e2f8
Compare
|
Ok, this turned into a smorgasbord blend of new functionality (wildcard redirect support) and project refreshers needed/motivated by the added unit tests (sdk update, re-org to support testing, ci test additions). Hoping not too onerous to review all together. |
vdice
changed the title
itowlson
left a comment
itowlson
left a comment
There was a problem hiding this comment.
Looks good to me - although my Go is very rusty so you may want a second opinion!
| spinhttp.Handle(r.HandleFunc) | ||
| } | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
This should no longer be needed for the component. Unless it's required for the tests or something?
Signed-off-by: Adam Reese <adam@reese.io>
|
I'm thrilled to try this out, I honestly wasn't looking forward to maintaining my own fork 🗡️ :D Giving it a shot right now before it's too late to provide you all with pre-release feedback, tyvm |
prerelease (our suggested changes for include_path got upstreamed in fermyon/spin-redirect - now let's test them out and 💟 stamp them) spinframework/spin-redirect#12 Signed-off-by: Kingdon B <kingdon@urmanac.com>
4 participants
Supersedes #11