ref(spin.toml): update with spinframework redirects#1497
Conversation
eff91d9 to
e1c6eb6
Compare
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1497-fdkgobkn.fermyon.app |
e1c6eb6 to
b93a73e
Compare
|
Opening up for review, but again needs spinframework/spin-docs#11 before merging. |
b93a73e to
0f16377
Compare
|
(pushed rebase commit to get broken links fixes; no other changes) |
|
I do want to mention that the catch-all Still, I don't think this is an issue - or at least not a major one - since there shouldn't be any local |
There will likely be external /spin references, though, on sites we don't control (or don't want to spend ages updating). Will they redirect correctly? |
Ah, yes, good reminder Ivan. Another option came to mind: we could add redirects for each of the single-path, top-level sections (eg all of the paths in the left-hand ToC section at https://developer.fermyon.com/spin/v3/index) to their appropriate destinations at spinframework.dev. Or, we could look into adding wildcard support to the spin-redirect module (again, I believe it would need a corresponding redirect on the spin-docs side to remove the inbound WDYT? |
|
We already kerjiggered the redirect module on the I think we'd looking at something like |
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
0f16377 to
4262067
Compare
|
Added a note above re: needing finalized wildcard redirect functionality (ref spinframework/spin-redirect#12). Once that is merged, I'll update the wasm module to the one built from main of that project. |
/spin/...redirector after the more-specific ones preceeding it... see further discussion belowNeeds:
Closes #1490