feat(redirect): add include_path (and trim_prefix) for wildcard redirect support#11
Closed
vdice wants to merge 1 commit intospinframework:mainfrom
Closed
feat(redirect): add include_path (and trim_prefix) for wildcard redirect support#11vdice wants to merge 1 commit intospinframework:mainfrom
vdice wants to merge 1 commit intospinframework:mainfrom
Conversation
Contributor
|
I realise I'm not the right reviewer anyway, but I think the README bit would be helpful to me to understand the usage and behaviour here (certainly no objection to doing both bits in one PR). |
…ect support Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
feat/wildcard-redirects
branch
from
fb020e6 to
1c51c0e
Compare
Contributor
Author
|
@itowlson thank you, review/feedback much appreciated. README.md addition added. Ran into a hiccup attempting to run unit tests... gonna pair with resident (tiny)go expert @adamreese tomorrow... |
Contributor
|
Thank you @vdice, the README changes made it click, especially the examples! |
Contributor
Author
|
Superseded by #12; @adamreese helped bump the sdk and perform some re-org to enable adding unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4
Thanks to @rajatjindal and @kingdonb for their reference implementation(s) mentioned in #4
If we're in favor of this general direction, I can add unit test(s).
And a mention in the READMEedit: added.I lumped in the 'trim prefix' functionality both because it is immediately useful for some work I have in flight 😅 and it seems like it would be a natural bit of functionality that users might want after including the request path. However, if this aspect doesn't land with reviewers and needs a rethink -- or we'd just prefer it in a separate change, I can defer to a follow-up.