-
Notifications
You must be signed in to change notification settings - Fork 0
MPT-15317 Report portal setup #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughGitHub Actions workflows are updated to increase timeout durations from 20 to 45 minutes across multiple pipelines. ReportPortal integration is added with dynamic launch identifiers derived from GitHub context. A new workflow for release branch pushes is introduced, consolidating build, test, and SonarCloud scanning steps. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/cron-main-e2e.yml(1 hunks).github/workflows/pr-build-merge.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (2)
.github/workflows/pr-build-merge.yml (1)
44-44: ReportPortal integration looks correct.The pytest command with ReportPortal flags is properly structured, and the environment variables are correctly referenced.
.github/workflows/cron-main-e2e.yml (1)
33-33: LGTM! Dynamic launch identifier is appropriate for scheduled workflows.The use of
github.ref_namecorrectly resolves to the branch name (main) for this cron-triggered workflow, creating a clear and consistent launch identifier:github-e2e-cron-main.
1efcfb1 to
9ebeb9d
Compare
8f4c187 to
e7d975b
Compare
e7d975b to
cca24e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
38-42: Inconsistent RP_LAUNCH value compared to other workflows.The
RP_LAUNCHvalue is hardcoded togithub-e2e-cron-main, which is inconsistent with the dynamic approach used in other workflows. Additionally, the "cron-main" suffix appears incorrect for a release workflow.Consider using a dynamic identifier similar to other workflows for better traceability:
env: - RP_LAUNCH: github-e2e-cron-main + RP_LAUNCH: github-e2e-release-${{ github.ref_name }} RP_ENDPOINT: ${{ secrets.RP_ENDPOINT }} RP_API_KEY: ${{ secrets.RP_API_KEY }}
🧹 Nitpick comments (1)
.github/workflows/push-release-branch.yml (1)
44-44: Consider using a more descriptive launch identifier pattern.The current
RP_LAUNCHpattern usesgithub.event.pull_request.number, which will always be undefined for push events, causing it to fall back togithub.run_number. While this works, usinggithub.ref_name(similar tocron-main-e2e.yml) would create more descriptive identifiers likegithub-e2e-push-mainorgithub-e2e-push-release/1.0instead ofgithub-e2e-push-123.Apply this diff for better consistency and clarity:
- RP_LAUNCH: github-e2e-${{ github.event_name }}-${{ github.event.pull_request.number || github.run_number }} + RP_LAUNCH: github-e2e-${{ github.event_name }}-${{ github.ref_name }}
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/cron-main-e2e.yml(2 hunks).github/workflows/pull-request.yml(2 hunks).github/workflows/push-release-branch.yml(1 hunks).github/workflows/release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (6)
.github/workflows/release.yml (1)
15-15: LGTM: Timeout increase aligns with other workflows.The timeout increase to 45 minutes is consistent with similar changes across other workflows in this PR and provides adequate time for E2E testing.
.github/workflows/cron-main-e2e.yml (2)
9-9: LGTM: Timeout increase aligns with other workflows.The timeout increase to 45 minutes is consistent with similar changes across other workflows in this PR.
33-33: LGTM: Dynamic launch identifier improves traceability.The dynamic
RP_LAUNCHidentifier usinggithub.ref_nameprovides better traceability compared to the previous hardcoded value..github/workflows/pull-request.yml (2)
14-14: LGTM: Timeout increase aligns with other workflows.The timeout increase to 45 minutes is consistent with similar changes across other workflows in this PR.
40-44: LGTM: ReportPortal integration properly implemented.The E2E test now includes ReportPortal integration with a dynamic launch identifier. The conditional expression
github.event.pull_request.number || github.run_numberprovides defensive fallback logic, though it's not strictly necessary since this workflow only triggers onpull_requestevents..github/workflows/push-release-branch.yml (1)
16-16: LGTM: Workflow structure and ReportPortal integration properly implemented.The workflow correctly:
- Sets an appropriate 45-minute timeout consistent with other workflows
- Builds test containers and creates environment files with necessary secrets
- Runs validation, E2E tests with ReportPortal integration, and SonarCloud scanning
- Ensures cleanup with the
always()condition on container shutdownAlso applies to: 24-46, 49-53, 55-57
| @@ -0,0 +1,57 @@ | |||
| name: PR build and merge | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Misleading workflow name for push event trigger.
The workflow is named "PR build and merge" but it triggers on push events to main and release/** branches (lines 4-7), not on pull requests. This creates confusion about the workflow's purpose.
Apply this diff to use a more accurate name:
-name: PR build and merge
+name: Push to main/release branches📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| name: PR build and merge | |
| name: Push to main/release branches |
🤖 Prompt for AI Agents
.github/workflows/push-release-branch.yml lines 1-1: the workflow name "PR build
and merge" is misleading because the workflow triggers on push to main and
release/** branches; update the name to accurately reflect push-triggered
behavior (for example "Push build and release" or "Push build and merge (push)")
by replacing the name value on line 1 with the chosen descriptive title so it
clearly documents the workflow purpose.
|



Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.