Skip to content

Conversation

@albertsola
Copy link
Contributor

@albertsola albertsola commented Jan 29, 2026

Closes MPT-16824

  • Renamed Report Portal launch naming from dynamic values to a fixed value (mpt-api-client-e2e) across CI/CD workflows
  • Introduced RP_LAUNCH_ATTR environment variable to capture launch attributes (ref and event name metadata)
  • Updated E2E test invocations to pass launch attributes via -o rp_launch_attributes option
  • Applied consistent changes to both push-release-branch.yml and release.yml workflow files

@albertsola albertsola requested a review from a team as a code owner January 29, 2026 10:51
@coderabbitai
Copy link

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Modified two GitHub Actions workflow files to standardize ReportPortal E2E test configuration by replacing dynamic launch names with a fixed value and introducing a new environment variable to capture launch attributes containing Git reference and event metadata.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Updates
.github/workflows/push-release-branch.yml, .github/workflows/release.yml
Changed RP_LAUNCH from dynamic GitHub event-based values to fixed string mpt-api-client-e2e. Added new RP_LAUNCH_ATTR environment variable with Git reference and event name metadata. Updated E2E test invocation to pass launch attributes via -o rp_launch_attributes option.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • MPT-15317 Report portal setup #167: Directly modifies the same GitHub Actions workflow files and ReportPortal E2E test configuration with related RP_LAUNCH and ReportPortal option changes.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key (MPT-16824) in the correct MPT-XXXX format, properly positioned at the beginning.
Test Coverage Required ✅ Passed The PR includes comprehensive test coverage with both E2E and unit tests in the tests/ directory alongside code modifications.
Single Commit Required ✅ Passed The PR contains exactly one commit (8fe745b: MPT-16824 Rename report portal launch and move to use attributes), meeting the single commit policy requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/pull-request.yml:
- Around line 39-45: Add an if: guard to both the "Create environment file" step
and the "Run E2E test" step so they are skipped when ReportPortal secrets are
unavailable (forked PRs); specifically, wrap the step definitions for "Create
environment file" and the step named "Run E2E test" with a condition that checks
secrets exist (for example using ${{ secrets.RP_API_KEY != '' &&
secrets.RP_ENDPOINT != '' }}), ensuring the E2E run and env file creation only
execute when those secrets are present.

@albertsola albertsola force-pushed the MPT-16824/Rename-report-portal-python-mpt-client-launch-names-and-use-attributes branch 4 times, most recently from 491e3b7 to 5e8d9dc Compare January 29, 2026 12:03
@albertsola albertsola force-pushed the MPT-16824/Rename-report-portal-python-mpt-client-launch-names-and-use-attributes branch from 5e8d9dc to 8fe745b Compare January 29, 2026 12:06
@sonarqubecloud
Copy link

@albertsola albertsola merged commit 8398818 into main Jan 29, 2026
4 checks passed
@albertsola albertsola deleted the MPT-16824/Rename-report-portal-python-mpt-client-launch-names-and-use-attributes branch January 29, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants