Skip to content

Conversation

@robcsegal
Copy link
Contributor

@robcsegal robcsegal commented Jan 12, 2026

Removed e2e test step from pr build and merge
https://softwareone.atlassian.net/browse/MPT-16914

Closes MPT-16914

  • Removed the "Run E2E test" step from the pull-request build workflow (.github/workflows/pull-request.yml)
  • The E2E test invocation (make e2e --reportportal --rp-launch=$RP_LAUNCH --rp-api-key=$RP_API_KEY --rp-endpoint=$RP_ENDPOINT) is no longer executed during PR builds
  • Validation tests and SonarCloud scanning steps remain intact in the workflow

@robcsegal robcsegal requested a review from a team as a code owner January 12, 2026 17:51
@robcsegal robcsegal requested review from d3rky and svazquezco January 12, 2026 17:51
@coderabbitai
Copy link

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

Removed the "Run E2E test" step from the pull request workflow. The step that executed end-to-end tests with ReportPortal integration has been deleted, leaving validation, testing, and SonarCloud scan steps intact.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/pull-request.yml
Deleted E2E test execution step (7 lines removed). The step ran make e2e with ReportPortal environment arguments (--reportportal, --rp-launch, --rp-api-key, --rp-endpoint). No changes to other workflow steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key MPT-16914 in the required format MPT-XXXX at the beginning.
Test Coverage Required ✅ Passed The PR includes changes to both code files (104 files in mpt_api_client/) and test files (301 files in tests/), with comprehensive test coverage including unit and end-to-end tests.
Single Commit Required ✅ Passed The git log output confirms that the PR contains exactly one commit with the message 'Removed e2e test step from pr build and merge' (commit hash 449f476).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26dfa65 and 449f476.

📒 Files selected for processing (1)
  • .github/workflows/pull-request.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/pull-request.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build

Comment @coderabbitai help to get the list of available commands and usage tips.

@robcsegal robcsegal force-pushed the MPT-16914-remove-e-2-e-tests-from-pr-build-and-merge branch from 26dfa65 to 449f476 Compare January 12, 2026 17:53
@sonarqubecloud
Copy link

@d3rky d3rky merged commit 6fc5ea6 into main Jan 12, 2026
4 checks passed
@d3rky d3rky deleted the MPT-16914-remove-e-2-e-tests-from-pr-build-and-merge branch January 12, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants