Fix typos and improve diagnostic messages for pd10129, pd10130, pd10141#75
Open
Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Open
Fix typos and improve diagnostic messages for pd10129, pd10130, pd10141#75Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves the diagnostic messages in
validation/rules/sbgn_pd.schto help users better understand validation failures.
Changes made
pd10129: Fixed typo "note" → "not". Added
value-ofto showwhich duplicate state variable and which node caused the failure.
pd10130: Replaced placeholder message "[NOT SURE]" with a proper
descriptive message explaining what arc class is required.
pd10141: Fixed typo "ouput" → "output". Removed confusing phrase
"pointing to the arcs". Added arc count so user knows what was found.
Why this matters
Clear error messages help users quickly identify and fix problems
in their SBGN diagrams without needing to read the full specification.