Improve diagnostic messages for af10101, af10102, af10103, af10104, af10109, af10110, af10112, af10113#79
Open
Drishti160803 wants to merge 1 commit intosbgn:masterfrom
Open
Conversation
…f10109, af10110, af10112, af10113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Improves the diagnostic messages in
validation/rules/sbgn_af.schto help users better understand validation failures.
Changes made
af10101: Replaced vague "Incorrect source reference for
influence arc" with descriptive message.
af10102: Replaced vague "Incorrect target reference for
influence arc" with descriptive message.
af10103: Replaced vague "This arc class is not allowed in
Activity Flow" with descriptive message.
af10104: Replaced vague "This glyph class is not allowed in
Activity Flow" with descriptive message.
af10109: Replaced vague "Incorrect source reference for arc
with class logic arc" with descriptive message.
af10110: Replaced vague "Incorrect target reference for arc
with class logic arc" with descriptive message.
af10112: Replaced vague "Incorrect source reference for arc
with class equivalence arc" with descriptive message.
af10113: Replaced vague "Incorrect target reference for arc
with class equivalence arc" with descriptive message.
Why this matters
Clear error messages help users quickly identify and fix problems
in their SBGN diagrams without needing to read the full specification.
Related
Follows same approach as PR #75 for sbgn_pd.sch and PR #78 for sbgn_er.sch