Upgrade to Phlex 2 #128
Merged
Upgrade to Phlex 2 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethhorsley
approved these changes
Nov 7, 2024
Member
sethhorsley
left a comment
sethhorsley
left a comment
There was a problem hiding this comment.
Great PR! If you think ruby-ui/ruby_ui#185 is ready I approved it so you can merge it in and then we can get this merged in too.
cirdes
reviewed
Nov 8, 2024
Gemfile
Outdated
| gem "phlex-rails", github: "phlex-ruby/phlex-rails" | ||
|
|
||
| gem "ruby_ui", github: "ruby-ui/ruby_ui", branch: "main" | ||
| gem "ruby_ui", github: "stephannv/ruby_ui", branch: "require_phlex_2" |
Contributor
There was a problem hiding this comment.
@stephannv , you can now point to ruby_ui again.
Contributor
Author
There was a problem hiding this comment.
I opened this PR ruby-ui/ruby_ui#186 to fix some stimulus problems before pointing to main again.
Contributor
Author
There was a problem hiding this comment.
I had to adapt some code to work with RubyUI, but I tried to minimize the changes.
stephannv
force-pushed
the
upgrade/phlex
branch
from
499ce66 to
a8b7bdd
Compare
stephannv
force-pushed
the
upgrade/phlex
branch
from
a8b7bdd to
07ad36e
Compare
cirdes
approved these changes
Nov 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take on upgrading the docs (I think we should rename this repo to docs, it makes more sense to me) to Phlex 2. We need ruby-ui/ruby_ui#185 to be merged.
This PR just makes things work with Phlex 2, in the following pull requests I will reorganize some code.