Fix stimulus controllers #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierry01
approved these changes
Nov 8, 2024
cirdes
approved these changes
Nov 8, 2024
Collaborator
cirdes
left a comment
cirdes
left a comment
There was a problem hiding this comment.
@stephannv , thanks for fixing that. It is so hard to choose the right form of writing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#179 follow up.
The
ruby_ui__accordion_target: "foo"will becomeruby-ui--accordion-target="foo", so usingruby_ui--accordion_targetas controller name would break a lot of components (eg. I could not merge ruby-ui/web#128 because when I point to rubyui main, all the component pages are broken).