Skip to content

Conversation

@sethhorsley
Copy link
Member

@sethhorsley sethhorsley commented Oct 8, 2024

This is updating phlex to version 2. There were quite a few changes needed

@sethhorsley sethhorsley requested a review from cirdes October 8, 2024 03:17
# frozen_string_literal: true

class Docs::ComponentsTable < ApplicationComponent
class Components::Docs::ComponentsTable < Components::Base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already are on Components directory, it means that you can use only Base make it less verbose

Components::Docs::ComponentsTable < Base

or even better:

module Components
  module Docs
    ComponentsTable < Base
    end
  end
end

bin/files_out Outdated
@@ -0,0 +1,34 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it useful?

@sethhorsley sethhorsley marked this pull request as draft November 4, 2024 23:22
@cirdes
Copy link
Contributor

cirdes commented Nov 8, 2024

fixed by #128

@cirdes cirdes closed this Nov 8, 2024
@sethhorsley sethhorsley deleted the update-to-phlex-2-beta branch November 10, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants