Modify Docker images and ROS distributions in test.yml#873
Open
mosfet80 wants to merge 3 commits intoros-tooling:mainfrom
Open
Modify Docker images and ROS distributions in test.yml#873mosfet80 wants to merge 3 commits intoros-tooling:mainfrom
mosfet80 wants to merge 3 commits intoros-tooling:mainfrom
Conversation
mosfet80
requested review from
MichaelOrlov and
emersonknapp
and removed request for
a team
Updated supported Docker images and ROS distributions in the CI workflow. Signed-off-by: mosfet80 <realeandrea@yahoo.it>
Signed-off-by: mosfet80 <realeandrea@yahoo.it>
Removed 'noetic' and 'iron' from allowed ROS distributions. Signed-off-by: mosfet80 <realeandrea@yahoo.it>
Comment on lines
-173
to
-174
| - run: .github/workflows/check-ros-distribution.sh "${{ matrix.ros_distribution }}" | ||
| if: matrix.ros_version == 1 |
Member
There was a problem hiding this comment.
I wouldn't remove this (or the script/file) for now, since there are plans to keep supporting ROS 1 (#854). However, you can remove Ubuntu 20.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated supported Docker images and ROS distributions in the CI workflow.