Update WIN ROS 2 binary release URLs and set Python version#874
Update WIN ROS 2 binary release URLs and set Python version#874mosfet80 wants to merge 1 commit intoros-tooling:mainfrom
Conversation
mosfet80
requested review from
christophebedard and
emersonknapp
and removed request for
a team
Signed-off-by: mosfet80 <realeandrea@yahoo.it>
mosfet80
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 10 10
Lines 257 257
Branches 27 27
=======================================
Hits 240 240
Misses 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| async function prepareRos2BuildEnvironment() { | ||
| // Currently targeted Python version for Windows according to REP 2000 | ||
| const python_dir = tc.find("Python", "3.8"); | ||
| const python_dir = tc.find("Python", "3.10"); |
There was a problem hiding this comment.
This is tricky because the Python version on Windows is not the same across all currently active distros. I think REP 2000 hasn't been updated since the Windows move to Pixi. Jazzy & Kilted are on Python 3.12.3 (https://github.com/ros2/ros2/blob/jazzy/pixi.toml#L99) and Humble is on 3.10.6 (https://github.com/ros2/ros2/blob/humble/pixi.toml#L103). However, since we already have just a single version not depending on the actual distro used, bumping to the new lower version is fine.
|
This should probably wait until #873 is merged, and then this can be rebased on |
2 participants
No description provided.