Skip to content

Support graceful shutdown in TiFlash again #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ti-chi-bot merged 11 commits into from
Jul 15, 2025
Merged

Support graceful shutdown in TiFlash again #10299

ti-chi-bot merged 11 commits into from
Jul 15, 2025

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Jul 10, 2025

What problem does this PR solve?

Issue Number: close #10266

Problem Summary:

What is changed and how it works?

Should merge #10298 first.

Support graceful shutdown in TiFlash again

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support graceful shutdown in TiFlash

gengliqi added 4 commits July 10, 2025 14:35
@gengliqi
Revert "Support graceful shutdown in TiFlash (pingcap#10267)"
674240d 
This reverts commit bec1390.
@gengliqi
graceful shutdown
70bafa0 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
4f882eb 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
update config
f5c00e7 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2025
@gengliqi
u
77d6aa5 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
JaySon-Huang
JaySon-Huang reviewed Jul 11, 2025
View reviewed changes
@gengliqi
address comments
1d1d0ba 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
JaySon-Huang
JaySon-Huang reviewed Jul 14, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, please resolve the conflicts

gengliqi added 2 commits July 14, 2025 17:02
@gengliqi
fix conflict
9837fa7 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
66b128f 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
JaySon-Huang
JaySon-Huang reviewed Jul 14, 2025
View reviewed changes
JaySon-Huang
JaySon-Huang approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 14, 2025
@gengliqi
address comments
0393bc7 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
Copy link
Contributor Author

gengliqi commented Jul 14, 2025

/retest

@gengliqi gengliqi requested a review from windtalker July 14, 2025 13:22
windtalker
windtalker reviewed Jul 15, 2025
View reviewed changes
gengliqi added 2 commits July 15, 2025 11:05
@gengliqi
u
fcf04e6 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
80e035d 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
windtalker
windtalker approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-14 09:13:43.142155289 +0000 UTC m=+2509475.865334270: ☑️ agreed by JaySon-Huang.
  • 2025-07-15 12:22:55.149494907 +0000 UTC m=+2607227.872673886: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit dc33637 into pingcap:master Jul 15, 2025
7 checks passed
gengliqi added a commit to gengliqi/tiflash that referenced this pull request Jul 15, 2025
@gengliqi
Support graceful shutdown in TiFlash again (pingcap#10299)
16204e3 
close pingcap#10266

Support graceful shutdown in TiFlash again

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
Copy link
Contributor Author

gengliqi commented Jul 15, 2025

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 15, 2025

@gengliqi: new pull request created to branch release-7.5: #10312.

Details

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jul 15, 2025
@gengliqi @ti-chi-bot
Support graceful shutdown in TiFlash again (pingcap#10299)
18c4684 
close pingcap#10266

Support graceful shutdown in TiFlash again

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 15, 2025
Open
12 tasks
@gengliqi gengliqi mentioned this pull request Jul 18, 2025
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 26, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #10368.

This was referenced Aug 26, 2025
Closed
Closed
@gengliqi gengliqi mentioned this pull request Aug 28, 2025
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Graceful shutdown in TiFlash

4 participants

@gengliqi @ti-chi-bot @windtalker @JaySon-Huang