Remove unnecessary wait for MPP tunnel destruction before shutdown #10313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bec1390.
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
ti-chi-bot
bot
added
release-note-none
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Contributor
Author
|
/hold |
ti-chi-bot
bot
added
do-not-merge/hold
Contributor
Author
|
/retest |
gengliqi
force-pushed
the
fix-graceful-shutdown
branch
from
cbddc48 to
405f04a
Compare
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
12 tasks
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
Author
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
ti-chi-bot
bot
added
the
needs-cherry-pick-release-8.5
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflash
that referenced
this pull request
Aug 26, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #10266
Problem Summary:
What is changed and how it works?
After #10299, TiFlash will wait for all MPPTasks to finish before shutdown.
Whether all MPP tasks have finished is determined by checking if
monitored_tasksis empty. InMPPTask,MPPTaskMonitorHelperis the last member to be destructed, and only when it is destructed willremoveMonitoredTaskbe called to remove the task id frommonitored_tasks.MPPTunnels are stored inMPPTunnelSet, and althoughMPPTunnelSetis held by a shared_ptr, there are actually only two references: one directly inMPPTask, and the other inside thestd::unique_ptr<DAGContext>also in MPPTask. Therefore, destroying theMPPTaskwill also destroy theMPPTunnel.Check List
Tests
Side effects
Documentation
Release note