Remove unnecessary wait for MPP tunnel destruction before shutdown (#10313) #10369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10313
What problem does this PR solve?
Issue Number: ref #10266
Problem Summary:
What is changed and how it works?
After #10299, TiFlash will wait for all MPPTasks to finish before shutdown.
Whether all MPP tasks have finished is determined by checking if
monitored_tasksis empty. InMPPTask,MPPTaskMonitorHelperis the last member to be destructed, and only when it is destructed willremoveMonitoredTaskbe called to remove the task id frommonitored_tasks.MPPTunnels are stored inMPPTunnelSet, and althoughMPPTunnelSetis held by a shared_ptr, there are actually only two references: one directly inMPPTask, and the other inside thestd::unique_ptr<DAGContext>also in MPPTask. Therefore, destroying theMPPTaskwill also destroy theMPPTunnel.Check List
Tests
Side effects
Documentation
Release note